[skills-daily] guard app auth route smoke alignment#110
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app-playwright-ci-debuggingto cover auth navigation drift betweenBottomTabBarandtests/e2e/smoke.spec.ts.Why
Main CI run 29308567967 failed in
lint-testatRun check-variant tasks, while security audit was skipped. The merged #108 implementation changed inaccessible tabs to callaccount.connect()and return, but the current smoke spec still asserts locked tabs navigate to/strategy,/activity, and/accountwith the sign-in gate. This is a project-specific app auth / route-smoke mismatch, not generic Playwright advice.Scope
Docs only:
.agents/skills/app-playwright-ci-debugging/SKILL.mdNo implementation, test, dependency, lockfile, or CI gate changes.
Validation
BottomTabBar, and currentsmoke.spec.ts.