[test-qa-hourly] Align guest locked-tab E2E behavior

[taiiiiiiiiiiii]

Summary

• Update the existing Playwright smoke test to match the merged guest navigation boundary.
• Verify unauthenticated clicks on Strategy, Activity, and Account stay on /podcast.
• Verify Podcast remains the selected tab after each locked-tab click.

Why

PR #108 changed BottomTabBar so locked guest tabs start the account connect flow and return before navigation. The main-branch smoke test still expected those clicks to navigate to authenticated routes, leaving implementation and CI assertions contradictory. This is the smallest test-only correction that protects the intended guest behavior without weakening any gate.

Scope

• One existing E2E test file
• No implementation, CI workflow, dependency, documentation, agent, or secret changes

Validation

Focused validation:

pnpm --filter @zapengine/app test:e2e -- tests/e2e/smoke.spec.ts

Broader validation when CI runs:

pnpm turbo run type-check lint test --filter=@zapengine/app
pnpm --filter @zapengine/app test:e2e

GitHub Actions is the source of truth for this run. Local checkout was unavailable because outbound DNS from the execution container could not resolve GitHub, so validation is delegated to the PR checks.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
zap-engine-frontend	Ready	Preview, Comment	Jul 14, 2026 6:22am
zap-engine-landing-page	Ready	Preview, Comment	Jul 14, 2026 6:22am

[taiiiiiiiiiiii]

Continuous QA run update (2026-07-14)

Inspected

• Recent main commits and merged QA PR [test-qa-hourly] Cover native Privy login failures #108
• Open Test QA PRs (none before this run)
• Current BottomTabBar guest-access branch
• apps/app/tests/e2e/smoke.spec.ts
• App test scripts and GitHub Actions CI #648
• Repository merge settings

Change

The merged implementation now starts sign-in and returns before navigating when a guest clicks Strategy, Activity, or Account, but the main-branch smoke test still asserted navigation to those locked routes. This PR changes only that contradictory E2E step:

• visit /podcast before each locked-tab check
• click each locked tab
• assert the URL remains /podcast
• assert Podcast remains selected

Validation

Requested focused command:

pnpm --filter @zapengine/app test:e2e -- tests/e2e/smoke.spec.ts

Requested broader commands:

pnpm turbo run type-check lint test --filter=@zapengine/app
pnpm --filter @zapengine/app test:e2e

Local execution result: not run — the execution container could not resolve github.com, so a checkout was unavailable. GitHub Actions CI #648 is the validation source of truth and is currently running. At this update, check-dead-env and deploy-gates passed; lint-test and coverage are in progress; verify-fly-docker was skipped as expected for this test-only diff.

Auto-merge

Not enabled. Repository setting allow_auto_merge=false blocks GitHub auto-merge.

[taiiiiiiiiiiii]

Continuous QA run update (2026-07-14)

• Rechecked the active Test QA PR, current diff, mergeability, and final GitHub Actions run for head 51188f4.
• CI #648 completed successfully. The test-only change now has full source-of-truth validation.
• No additional commit was added: the PR is already a focused one-file correction aligning the guest locked-tab smoke assertions with the merged BottomTabBar behavior.
• Validation recorded by the PR:
  • pnpm --filter @zapengine/app test:e2e -- tests/e2e/smoke.spec.ts
  • pnpm turbo run type-check lint test --filter=@zapengine/app
  • pnpm --filter @zapengine/app test:e2e
• GitHub Actions CI #648: passed.
• Auto-merge will be attempted now; if rejected, the blocker is repository-level auto-merge availability/settings.
• Next QA target after merge: component-level coverage for repeated guest clicks on locked tabs, ensuring only the connect flow runs and navigation is never emitted.