Implement Component and LanguageServer traits#271
Merged
Conversation
tartarughina
commented
Jun 13, 2026
tartarughina
commented
Collaborator
- Prepare the extension to offer multiple LSPs
- Standardize retrieval and download of components
- Simplify debugger interaction with jdtls
- Prepare the extension to offer multiple LSPs - Standardize retrieval and download of components - Simplify debugger interaction with jdtls
Collaborator
Author
|
This refactor is the first step to vend multiple LSPs, following the pattern used in the Ruby extension. Alongside it, I created the Component trait to standardize as much as possible the functions to call when downloading and retrieving bundles or components. I finally simplified the Debugger by removing the overkill LspWrapper struct to save the current workspace. To verify that nothing broke I had next to each other two Java projects and I was able to debug without issue, asserting no regression was caused by the removal of the Arc<RwLock<>>. |
playdohface
reviewed
Jun 15, 2026
playdohface
left a comment
playdohface
left a comment
Collaborator
There was a problem hiding this comment.
I did my usual round of testing and nothing broke 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.