fix(deps): isolate sharp 0.35.4 security lockfile update - #56
Draft
zedarvates wants to merge 1 commit into
Draft
zedarvates wants to merge 1 commit into
zedarvates wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The root lockfile resolves sharp 0.35.0, which is affected by the libheif advisory GHSA-rgj7-g3m4-5g8c. The first patched sharp release is 0.35.4; its prebuilt libraries provide libheif 1.23.2.
This draft changes only
package-lock.json: sharp 0.35.0 → 0.35.4, the associated native packages to 0.35.4, and their libvips packages 1.3.0 → 1.3.3. All 27 changed package entries belong to this dependency family. The manifest's existing^0.35.0range accepts the patched resolution. Joi, Vitest, other lockfiles, and application code are unchanged. This is a focused alternative for the sharp portion of #55.Validation on a complete checkout based on
5b6c83bd26f60f7eb5e4da53f958f2d3b06edb4a, with Linux x64/glibc 2.39, Node 24.19.0 and npm 11.9.0:ELECTRON_SKIP_BINARY_DOWNLOAD=1 npm ci --no-audit --no-fundaddons/content_sensitivity/tests/test_censorship.jscensorImageand full PNG decoding; custom-region extraction/composition;pixelateFiledisk round trip; malformed input rejectionnpm audit --package-lock-only --json, before/aftergit diff --checkpassedThe image checks establish execution and output compatibility; they do not assess censorship strength. The npm audit result is scoped to the root dependency graph and is not a clean audit of the whole repository.
Reproduce the existing targeted suite with a required native-library preflight:
ELECTRON_SKIP_BINARY_DOWNLOAD=1 npm ci --no-audit --no-fund node -e 'const a=require("node:assert/strict"),s=require("sharp"); a.equal(s.versions.sharp,"0.35.4"); a.equal(s.versions.heif,"1.23.2"); console.log(s.versions); require("./addons/content_sensitivity/tests/test_censorship.js")' npm audit --package-lock-only --json git diff --checkThe audit command still exits 1 for the unchanged Joi finding.
Tested lockfile SHA-256:
44561b67b05de02fa0f91c78fdd36361450eb69fb10edaddddf3aba02e9f1402.Published lockfile Git blob:
f91c26855f4067f134b11a308672ecfda174e847.Published head:
215fe134b028962404a8a230df5ce95828c2a277. Its complete Git tree (5e260447b4440e11afa1c32b7c42d9658d66be03) was fetched and verified identical to the locally tested tree.Before a merge decision: directly confirm the package, manifest and advisory on repository Dependabot alert #463. Its page returned a signed-out 404 in this session, and the secure sign-in attempt reported that this ChatGPT client does not support secure browser authentication. The exact alert mapping therefore remains unverified; the fix above is independently supported by the maintainer advisory and the before/after npm audit. No pull-request Actions runs were reported for the published head at verification time. The existing Actions workflow at this base only covers Harbour paths and does not run these root/addon checks. Full Electron packaging and Windows/macOS runtime validation have not been performed. No merge or auto-merge is requested.