fix(asset-creator): handle ComfyUI timeouts and terminal status - #60
Draft
zedarvates wants to merge 1 commit into
Draft
zedarvates wants to merge 1 commit into
zedarvates wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Le client Asset Creator pouvait traiter des sorties partielles comme une réussite alors que ComfyUI déclarait un échec. Ses appels HTTP, sauf le contrôle de disponibilité, n'avaient pas de délai explicite ; le budget de polling ne suffisait donc pas à interrompre une requête silencieuse.
Cette PR corrige le client existant :
status_str="success"etcompleted=true; les erreurs restent prioritaires sur les sorties partielles ;ComfyUIWaitTimeout(TimeoutError)conserveprompt_id, distingue expiration du suivi et timeout HTTP, et garde la cause réseau ;COMFYUI_CLIENT.md.La reprise concerne le client Python. Aucun service payant, modèle, nouvel orchestrateur ou nouvelle dépendance de production n'est ajouté.
Validation :
main@5b6c83bavec réponses simulées : retour des sorties d'un prompt en erreur et absence de timeout sur la lecture d'historique.git diff --checkpasse.Commande :
python -m unittest discover -s tests/asset_creator -p test_comfyui_client.py -v(avec Requests installé).Limites :
Le contrat de statut a été vérifié dans ComfyUI execution.py et main.py, et les limites HTTP dans la documentation Requests.
Suite de l'audit Asset Factory / ComfyUI (#58, #59). Correction indépendante, fondée directement sur
main, dont le client est identique à celui des deux PR précédentes.