Repository navigation
SetDefaultCompileFlags: Allow --coverage without --build-type=debug - #149
Merged
awelzel merged 1 commit intoSep 11, 2026
Merged
Conversation
Member
|
Does coverage mean anything without the debug symbols? I actually don't know if it would miss anything or not. |
Contributor
Author
Hmm, so I usually put |
timwoj
approved these changes
Sep 9, 2026
timwoj
left a comment
timwoj
left a comment
Member
There was a problem hiding this comment.
Finally coming back to this I don't see anything wrong with it.
awelzel
deleted the
topic/awelzel/allow-coverage-in-none-debug-builds
branch
September 11, 2026 22:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems unnecessary restrictive and surprising as it silently discards
--coveragefor non debug builds. Even if coverage outside of debug builds might not be recommended, enabling it should be possible.