Repository navigation
docs: bring every doc in line with the code after API parity - #29
Merged
Merged
Conversation
README / documentation.md - Security: where the key travels per API (query/body, Bearer header, Warmup API-Key header), https enforced on every base URL, redaction, key checks. - Errors: ZBClientException vs ZBApiException, status_code, unknown enum values. - Region note: file-based APIs always use bulkapi.zerobounce.net. - Email finder: first_name optional, use_post; stream=True on the other downloads. - Other hosts: BULK_ROOT_URL (S3/SFTP) and the https requirement. - guess_format example crashed (str + response object). - Development: install with [test] and the pinned ruff, lint and pytest commands, the live suite's real command; the old `python -m tests` output (contradictory counts) is gone. AGENTS.md: all offline suites, pinned ruff, every optional parameter, key placement per API, the https guard and regional warning, the redaction pattern. CONTRIBUTING.md: branch from and PR against master (not main), Conventional Commits, CHANGELOG entry, docs-only endpoints rule. SECURITY.md: current guidance (https enforced, Python 3.10+, query-string logs, separate Warmup key). CHANGELOG.md: the missing 2.2.4 section (CI-only release) and compare link. Dockerfile: runs every offline suite, not just zero_bounce_test_case.py. tests/__main__.py: runs every offline suite and no longer includes the live API suite, which called the real API whenever ZEROBOUNCE_API_KEY was set. pyproject.toml: keywords and Documentation / Changelog / Issues URLs. ZeroBounce class docstring: what it covers, and ZeroBounceWarmup for Warmup. Every Python example in README.md and documentation.md runs against the offline fakes without error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A full pass over every doc in the repo after #28, checked against the code.
Authorization: Bearer, WarmupAPI-Key), https enforced on every base URL, redaction and key checks. The old text saidapi_keyis always a query parameter.ZBClientExceptionvsZBApiException,status_code, unknown enum values).bulkapi.zerobounce.net.first_nameoptional,use_post.stream=Trueon every download example.BULK_ROOT_URLand the https rule.guess_formatexample crashed ("..." + response).[test]and the pinnedruff; lint andpytestcommands; the live suite's real command. The oldpython -m testsoutput showed contradictory counts.ruff, every optional parameter, key placement per API, the https guard and regional warning, the redaction-outside-exceptpattern.master(it saidmain), Conventional Commits, CHANGELOG entry, docs-only endpoints rule.[2.2.4]section (a CI-only release) and its compare link.zero_bounce_test_case.py).ZEROBOUNCE_API_KEYwas set.ZeroBouncedocstring: what it covers;ZeroBounceWarmupfor Warmup.Test plan
ruff check src tests,python -m compileall -q src tests,python -m pytest(127 passed on Python 3.12 and 3.9)python -m testsruns the offline suites only🤖 Generated with Claude Code