Add e_qcstatem_psd2_ncaid_format: NCAId syntax check for PSD2 QCStatements - #1074
Merged
Merged
Conversation
- Assert the exact Details string for the Error case in TestEtsiQcStatemPsd2Valid so the test still catches a regression in the ASN.1 re-encoding check, not just a change in lint status. - Add TestParseQcStatemPsd2UnmarshalFailure to cover the previously untested "asn1.Unmarshal fails outright" branch of the PSD2 case in ParseQcStatem, using truncated statementInfo bytes. - Rename EtsiTS119495_V1_1_2_Date to EtsiTs119495_V1_1_2_Date to match the mixed-case naming convention used by sibling ETSI date constants.
…P_PA NA carve-out)
- Add QcStmtEtsiPsd2NcaIdPspCbValidCert01.pem fixture and Pass case to cover the previously-untested IdEtsiPsd2RolePspCb carve-out branch. - Assert out.Details (not just out.Status) for the three Error fixtures. - Add QcStmtEtsiPsd2WrongEncodingCert01.pem as an Error case to cover the structural-deferral branch (GetErrorInfo() != "") in Execute.
…th ncaname_valid twin)
Full integration corpus (789,896 certs): 2 certificates from the same issuer/subject (Firmaprofesional, eurobits.es, PSD2 role PSP_AI) have NCAId = "BE" -- missing the required <country>-<identifier> structure (should be "ES-BE", per the same cert's subject:organizationIdentifier of PSDES-BE-6887). A genuine pre-existing issuer error, not a false positive.
Repoint Citation and the embedded clause text at V1.8.1 (2026-04), and
add GEN-5.2.3-5 (the NCAId "NA" carve-out) to the formal Citation field
-- it was only mentioned in the comment before. The block comment had
also been quoting V1.8.1's wording ("ISO 3166-1", "Competent Authority")
while labeled as V1.1.2, which actually reads "ISO 3166", "NCA country".
# Conflicts: # v3/lints/etsi/lint_qcstatem_psd2_valid.go # v3/util/oid.go # v3/util/qc_stmt.go # v3/util/qc_stmt_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
e_qcstatem_psd2_ncaid_formatthat checks a PSD2 QCStatement's NCAId matches the required<country>-<identifier>syntax (ETSI TS 119 495, GEN-5.2.3-2/GEN-5.2.3-5).Integration corpus (789,896 certs) found 2 real-world errors: same issuer/subject (Firmaprofesional, eurobits.es), NCAId "BE" missing its country prefix (should be "ES-BE"). Recorded as expected.