Add e_/w_qcstatem_psd2_orgid_format: organizationIdentifier format check for PSD2 certificates - #1079
Merged
Merged
Conversation
- Assert the exact Details string for the Error case in TestEtsiQcStatemPsd2Valid so the test still catches a regression in the ASN.1 re-encoding check, not just a change in lint status. - Add TestParseQcStatemPsd2UnmarshalFailure to cover the previously untested "asn1.Unmarshal fails outright" branch of the PSD2 case in ParseQcStatem, using truncated statementInfo bytes. - Rename EtsiTS119495_V1_1_2_Date to EtsiTs119495_V1_1_2_Date to match the mixed-case naming convention used by sibling ETSI date constants.
…lformed/bad-country)
…Warn message wording
…egex capture groups
…lint The repo's custom lint-format checker (integration/lints) requires every zlint lint file's first function declaration to be func init(). Reorder the shared helpers after init() rather than before it.
psd2OrgIdCheckApplies now checks the Subject-DN conditions (which disqualify the common non-PSD2 case) before parsing the qcStatements extension, skipping the ASN.1 unmarshal for certificates that don't carry a "PSD"-prefixed organizationIdentifier. Also moves the "why Execute doesn't defer on GetErrorInfo()" rationale to live once above psd2OrgIdCheckApplies (the function it actually explains) instead of being duplicated verbatim in both lints' Execute methods.
# Conflicts: # v3/lints/etsi/lint_qcstatem_psd2_valid.go # v3/util/qc_stmt.go # v3/util/qc_stmt_test.go # v3/util/time.go
# Conflicts: # v3/util/time.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
e_qcstatem_psd2_orgid_formatandw_qcstatem_psd2_orgid_formatthat check a PSD2 certificate's subject:organizationIdentifier matches thePSD<country>-<NCAid>-<PSPid>structure (ETSI TS 119 495, GEN-5.2.1-3 — Error before V1.5.1's shall→should downgrade, Warn from V1.5.1 onward).