Repository navigation
mode="function" #318
Description
BUG/PROBLEM REPORT
mode="function" is allowed for compile_restricted funcion (
RestrictedPython/src/RestrictedPython/compile.py
Lines 195 to 202 in a2891c0
from RestrictedPython.compile import compile_restricted
s = """
def f():
pass
"""
compile_restricted(s, mode="function")What version of Python and Zope/Addons I am using:
master branch without addons (python 3.10.11, 3.11.9, 3.12.10, 3.13.13, 3.14.5, 3.15.0b2)
Activity
zedzhen commentedon Jun 3, 2026
I can create a PR, but I need to figure out what the solution is. Disallow "function" or,
by analogy withor something else?compile_restricted_function, replace it with "exec"upd: just replacing it won't do any good.
icemac commentedon Jun 12, 2026
@loechel Do you remember what this
functionmode was for?zedzhen commentedon Jun 16, 2026
it's not work on RestrictedPython 6.0 (03.11.2022) and python 3.6 (minimum version for RestrictedPython 6.0).
It probably never worked.
History:
0) commit 0
When developing the new api in version 4.0,
compile_restricted_functionhad a signature matching the backwardcompile_restricted_*methods.compile_restrictedcalledcompile_restricted_[mode]The function
_compile_restricted_modeis highlighted,compile_restricted_functioncalls it with mode='function', and the functioncompile_restrictedstarts calling_compile_restricted_modedirectly with mode='exec'.1.1) commit 1.1
The
compile_restrictedfunction starts calling_compile_restricted_modedirectly with mode=mode.The signature of the
compile_restricted_functionfunction is changing.The function
compile_restricted_functionhas an implementation.I think we should just delete it. And since it didn't actually work in any release, I think you don't need to increase the major version number.
@icemac
icemac commentedon Jun 19, 2026
@zedzhen Thank you for the analysis. Yes, let's delete
compile_restricted_functionand its mentionings in the documentation. If it never has worked, nobody ever could have used it.Would you mind to create an independent PR just for the removal?
zedzhen commentedon Jun 19, 2026
The
compile_restricted_functionis working.When developing the new API in version 4.0,
compile_restricted_functionhad a signature matchingcompile_restricted_*(and was equivalent tocompile_restricted_exec) and it could be called ascompile_restricted(..., mode='function'), but then (before the release) the signature was changed, and the callcompile_restricted(..., mode='function'), stopped working.Therefore,
compile_restricted_functionshould not be deleted, andcompile_restricted(..., mode='function')is deleted in #326.icemac commentedon Jun 19, 2026
@zedzhen Thank you for the clarification. I just merged #326.
add comment and update type hint after fix zopefoundation#318
Type Annotations for RestrictedPython (#317)