Repository navigation
chore(vendor): track zvec 89ba922 (validation before merge) - #22
Merged
Merged
Conversation
Upstream moved three commits ahead of c133f20: - 1a57305 refactor: migrate index storage reads to MemoryBlock (#812) - f8cdeaf perf(flat): isolate query metadata from segment cache locking (#825) - 89ba922 ci: strip debug symbols from Android prebuilt SDK libraries (#702) No C-API change: c_api.h, export.h and src/binding/c/ are identical at both revisions, so no Rust adaptation is needed. Opened to validate the bump before merging it. The Nightly Coverage workflow does not build vendor/zvec; it clones upstream main unpinned, and its run on main failed test_collection_fetch_with_options with Arrow reporting "No function registered with name: array_take" from memory_forward_store.cc -- a file unchanged across this range, in a range where no CMakeLists.txt changed. This PR's matrix builds the pinned revision with our own flags on all five platforms and decides whether the bump is safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up vendor bump: upstream moved three more commits ahead of
c133f20(merged in #21).vendor/zvecc133f20→89ba922(upstreammainHEAD):1a57305refactor: migrate index storage reads to MemoryBlock (#812) — large refactor acrosssrc/core/algorithm/*andsrc/db/index/*; no CMake changes.f8cdeafperf(flat): isolate query metadata from segment cache locking (#825) — 3 lines.89ba922ci: strip debug symbols from Android prebuilt SDK libraries (#702) — upstream workflow only.No C-API change:
git diff --stat c133f20..89ba922 -- src/include/zvec/c_api.h src/include/zvec/export.h src/binding/cis empty, so no Rust adaptation is needed.Why this PR is under validation before merging
The Nightly Coverage run dispatched on
mainat6949471(39360665059) failed on linux-x64 with:That workflow does not build
vendor/zvec; likefuzz.ymlit runsgit clone --depth 1 https://github.com/alibaba/zvec.git ../zvec(nightly-coverage.yml:56), so it built upstreammain— i.e. the three commits in this PR — rather than the pinnedc133f20.Evidence that the pin itself is fine: PR #21's CI built
vendor/zvecatc133f20andtest_collection_fetch_with_optionspassed (integration_test: 72 passed, 0 failed) on all five platforms. The last Nightly Coverage run that built an older upstreammain(39105347636, Oct 18) was green with the same workflow flags, so the flags are not the difference — the upstream code is.arrow::compute::Takeis called fromsrc/db/index/storage/memory_forward_store.cc:243, a file that is unchanged acrossc133f20..89ba922, and none of the three commits touch aCMakeLists.txt, so this looks like1a57305perturbing which Arrow compute kernel objects the linker pulls intolibzvec_c_api("No function registered" is Arrow's compute registry missing thearray_takekernel).This PR's CI is the experiment: it builds
vendor/zvecat89ba922with our own flags on all five platforms. It will not be merged unlessCheck & Testis green; ifintegration_testfails the same way, the bump is held back and the regression belongs upstream.