Version Packages - #498
Merged
Merged
Version Packages#498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to develop, this PR will be updated.
Releases
@10up/babel-preset-default@3.0.0
Major Changes
e40dc56: Support and default to Node 24
Node 24 (current Active LTS) is now the version the toolkit is developed, tested and released against, and the minimum supported Node version is now 20. Node 16 and 18 are past end-of-life and have been dropped from the test matrix; CI now covers Node 20, 22 and 24.
This is a breaking change only in the sense that
enginesno longer permits Node 16/18. No build, config or API behaviour has changed — seeUPGRADING.mdfor details.@10up/eslint-config@5.0.0
Major Changes
e40dc56: Support and default to Node 24
Node 24 (current Active LTS) is now the version the toolkit is developed, tested and released against, and the minimum supported Node version is now 20. Node 16 and 18 are past end-of-life and have been dropped from the test matrix; CI now covers Node 20, 22 and 24.
This is a breaking change only in the sense that
enginesno longer permits Node 16/18. No build, config or API behaviour has changed — seeUPGRADING.mdfor details.Patch Changes
@10up/stylelint-config@4.0.0
Major Changes
e40dc56: Support and default to Node 24
Node 24 (current Active LTS) is now the version the toolkit is developed, tested and released against, and the minimum supported Node version is now 20. Node 16 and 18 are past end-of-life and have been dropped from the test matrix; CI now covers Node 20, 22 and 24.
This is a breaking change only in the sense that
enginesno longer permits Node 16/18. No build, config or API behaviour has changed — seeUPGRADING.mdfor details.Minor Changes
2535d76: Align stylelint configuration with 10up CSS Engineering Best Practices
This release adds several new rules to enforce 10up CSS best practices:
Specificity Controls:
selector-max-specificityrule limiting specificity to 0,2,1selector-max-idrule disallowing ID selectors for stylingmax-nesting-depthrule limiting nesting to 2 levelsno-descending-specificityruleCode Quality:
declaration-no-importantrule disallowing !importantselector-no-qualifying-typerule preventing type+class qualifiersshorthand-property-no-redundant-valuesrule for efficient CSSNaming Conventions:
selector-class-patternrule enforcing kebab-case for classes, with optional BEM__elementand--modifiersuffixes. camelCase and snake_case are rejected;.card__header--compactand WordPress core classes such as.wp-block-group__inner-containerare allowedkeyframes-name-patternrule enforcing kebab-case for animationsBreaking Changes:
Projects using this configuration may need to update existing CSS to comply with the new rules. The most impactful changes are:
__element/--modifiersuffixes (no camelCase or snake_case, and no leading hyphen such as.-secondary)!importantis reported as an error, but best practices reserve it for truly exceptional cases such asprefers-reduced-motionoverrides. Disable it narrowly at the call site with a comment explaining why, rather than turning the rule off project-wide.See the updated README for detailed documentation on each rule and how to override them if needed for your project.
10up-toolkit@7.0.0
Major Changes
e40dc56: Support and default to Node 24
Node 24 (current Active LTS) is now the version the toolkit is developed, tested and released against, and the minimum supported Node version is now 20. Node 16 and 18 are past end-of-life and have been dropped from the test matrix; CI now covers Node 20, 22 and 24.
This is a breaking change only in the sense that
enginesno longer permits Node 16/18. No build, config or API behaviour has changed — seeUPGRADING.mdfor details.Minor Changes
b08fb3b: Add WordPress Block Metadata Collections API support
Integrate automatic generation of block metadata manifest files to improve block registration performance in WordPress 6.7+. When enabled, toolkit generates a PHP file (
blocks-manifest.php) containing all block metadata from a single source, eliminating the need to read multipleblock.jsonfiles at runtime.New Features:
useBlockManifestconfiguration option (boolean, default:false)--block-manifestCLI flag for one-time manifest generationBuildBlocksManifestPluginwebpack plugin that hooks into build completionConfiguration:
Enable via package.json:
{ "10up-toolkit": { "useBlockAssets": true, "useBlockManifest": true } }Or via CLI flag:
WordPress Integration:
Register the collection and automatically register all blocks:
Benefits:
The manifest is generated in
dist/blocks-manifest.phpand works seamlessly with the existinguseBlockAssetsworkflow.dda2bbd: Security: Fix critical and high severity CVEs in transitive dependencies
Minimum Node.js version is now 20.9. The major dependency bumps required
for the security fixes (copy-webpack-plugin@^14, image-minimizer-webpack-plugin@^5)
require Node ≥20.9. Node 16 and 18 are EOL and no longer supported.
Bump
copy-webpack-pluginfrom ^11 to ^14 — resolves serialize-javascript RCE (GHSA-5c6j-r48x-rmvq) and CPU exhaustion (GHSA-qj8w-gfj5-8c6v)Bump
image-minimizer-webpack-pluginfrom ^3 to ^5 — same serialize-javascript fixDowngrade
@linaria/*from ^5 to ^4.5.4 in 10up-theme — removes happy-dom@10 CVE-2024-53382Bump
webpackbarfrom ^6 to ^7 — webpack 5.96+ added stricter ProgressPlugin schema validation that webpackbar 6 fails by passing non-schema options to itsProgressPluginparent; webpackbar 7 routes those options to a separate instance and is forward-compatible. Avoids needing to pin webpack downstream.Switch the toolkit's linaria integration from the meta-package
@linaria/webpack-loaderto@linaria/webpack5-loaderdirectly. The meta-package always installs both the webpack 4 and webpack 5 loaders, dragging webpack@4.47.0 (and a long tail of vulnerable transitive deps —serialize-javascript@<7.0.5,braces@2,micromatch@3,terser-webpack-plugin@1, etc.) into every install even though only webpack 5 is used. Importing the webpack5 loader directly drops the webpack 4 chain entirely, fixing those CVEs at the dep-tree level instead of via root-leveloverrides(which don't propagate to consumers of the published10up-toolkit).Migration for
10up-toolkitconsumers using linaria: replace"@linaria/webpack-loader"with"@linaria/webpack5-loader"in your project'spackage.jsonand update anyloader: '@linaria/webpack-loader'references in custom webpack configs. No API changes — the webpack5 loader is the same module the meta-package was delegating to.Bump
engines.nodeto>=20.9.0across the toolkit, eslint-config, stylelint-config, and 10up-theme workspaces. Update CI matrix to test on Node 20 + 22 only.Reduces critical/high vulnerabilities to 0. The serialize-javascript / braces / micromatch fixes propagate to consumers via the linaria webpack5-loader swap. Remaining low/moderate issues are in dev tooling (
@wordpress/env,jest-environment-jsdom, etc.) with no upstream fixes available yet.Note on remaining monorepo-only
overridesThe root
package.jsonkeeps threeoverridesas documented temporary workarounds. npm only honorsoverridesdeclared in the top-level project, so these apply only to this monorepo'snpm install/npm ci— they do not flow through to consumers installing10up-toolkitas a dependency. None of the three are blocking consumer security:minimatch: ^9.0.7— patches a ReDoS in@typescript-eslint@^6's pinned minimatch. Resolved permanently by upgrading@typescript-eslintto v8 (deferred — major bump on@10up/eslint-configwith consumer impact).stylelint-declaration-strict-value: ~1.10.11— keeps the plugin on the stylelint 15 line. The 1.11.x line bumped its peer to stylelint ≥16, conflicting with@10up/stylelint-config's stylelint 15 peer. Resolved by upgrading the stylelint config to v16 (deferred — major bump with consumer impact).@types/node: ^20.19.0— workaround for@manypkg/find-root@1's legacy@types/node@^12.7.1declaration, which conflicts with@inquirer/external-editor's@types/node>=18peer. Upstream blocker:@changesets/cli@2.xstill ships with@manypkg/find-root@1; only the@changesets/cli@3.0.0-next.2pre-release has migrated.Follow-up security bumps (added when restacking onto Node 24 support)
New advisories landed against the original set of fixes. Additionally addressed:
Bump
postcssfrom^8.4.31to^8.5.26— resolves path traversal in previous-source-map auto-loading viasourceMappingURL(GHSA-6g55-p6wh-862q and its incomplete-fix follow-up).Bump
svgofrom^3.2.0to^4.0.2— resolves theremoveScriptsadvisory, where the plugin left some executable scripts intact. This is directly relevant since this is the code path that sanitises project SVGs.Migration for consumers with a custom
svgo.config.js: svgo 4 removedremoveViewBoxfrompreset-default, and changed parts of the plugin config format. The toolkit's own default config was updated accordingly (viewBox is preserved by default in svgo 4, so the previousoverrides: { removeViewBox: false }is both unnecessary and no longer valid). Custom svgo configs written for svgo 3 may need updating — see the svgo 4 release notes.Bump
@wordpress/envinprojects/10up-themefrom^10.10.0to^11.13.0— dev-only, resolves anextract-zipsymlink path traversal.Follow-up security bumps (npm_and_yarn dependabot sweep)
The
sharpbump this changeset deferred, along withwebpack-dev-server@5.2.6,@babel/core@^7.29.6and a set of patched transitives, landed separately — see the"land the
sharpbump" changeset for the detail.npm auditis now at 0 critical,with 5 high and 7 moderate remaining; those are covered below.
Known remaining advisories
npm auditstill reports issues that are not fixable within this PR:webpack-dev-server(moderate —http-proxy-middleware,sockjs→uuid).webpack-dev-server@5.2.6plus the patchedws,websocket-driverandbody-parsertransitives clear the criticals that the 5.x line previously carried. What is left is moderate-only and still scoped to the whole 5.x line; clearing it needswebpack-dev-server@6, a major upgrade with dev-server config changes (express 5, chokidar 5) that deserves its own PR and HMR testing. These affect the local dev server only, not built output.@wordpress/env→@wp-playground/*→adm-zip,tmp(dev-only).@wordpress/env@11.13.0is the latest release and still pullsadm-zip@0.5.x; needs an upstream fix.postcss@8.5.14still present in this monorepo's tree, hoisted viastylelint@15/cssnanotransitives. Consumers of the published10up-toolkitare not affected, because the toolkit declarespostcss@^8.5.26and npm resolves a single satisfying copy forpostcss-loader. Clearing it here depends on the deferredstylelint@16upgrade.js-yaml(high, via theeslint@8chain) andajv(moderate, same chain). Build/test-time only; both need the deferredeslint@9/@typescript-eslint@8upgrade. Theimmutable,brace-expansion,form-dataandwsadvisories previously listed here are fixed by the bumps above.uuid(moderate) viasockjsand@10up/block-components. The advisory is a missing buffer bounds check inv3/v5/v6, and only when an explicitbufargument is passed.sockjscallsuuid.v4()with no arguments, so it is not reachable there. Awaiting upstream bumps touuid@>=11.1.1.Patch Changes
5e11087: Security: land the
sharpbump and reconcile the dependabot manifest with its lockfileBumps
sharpfrom0.32.6to0.35.3, resolving the inherited libvips advisories thatthe previous security sweep had to defer, plus
webpack-dev-serverto^5.2.6and thepatched transitives
@babel/core@^7.29.6,qs@6.15.3,brace-expansion@2.1.4,esbuild@0.28.2,form-data@4.0.6,immutable@5.1.9,tmp@0.2.7,ws@7.5.13,websocket-driver@0.7.5andbody-parser@1.20.6.npm auditgoes from 2 critical to 0.AVIF minification fix. sharp reports
.avifinput as formatheif, and from 0.35 theheif encoder requires an explicit compression.
config.heifinoptimization.jsis now{ ...config.avif, compression: 'av1' }; without it,heif()throwsExpected one of: av1, hevc for compression but received undefinedand every.avifasset fails minification. Projects that run
.aviffiles through the build are the onesaffected — no config change is needed on their side.
Why the earlier
sharpbackout no longer applies. That revert was correct at the time:from 0.33 onward sharp ships its prebuilt binaries as per-platform optional dependencies
(
@img/sharp-linux-x64,@img/sharp-win32-x64, …), and the lockfile generated thenrecorded only the host (darwin-arm64) entries, breaking
npm cion Linux and Windows with"Could not load the
sharpmodule using the linux-x64 runtime". npm now records everyplatform's entries regardless of the resolving host — this lockfile carries all 26
@img/sharp-*entries (darwin, linux, linuxmusl, win32, freebsd, wasm), and a from-scratchre-resolve on macOS reproduces all 26 rather than pruning to darwin. Verified in a real
linux/amd64container thatnpm cisucceeds andrequire('sharp')loads the linux-x64binary and encodes AVIF on both Node 20 (npm 10.8.2) and Node 24 (npm 11.17).
Worth a glance after any future lockfile regeneration: the
@img/sharp-*entry countshould stay at 26.
1fe01b6: Fix: Update "Dependency Extraction Webpack Plugin" Dependency
d22ef93: Fix block entrypoint tests failing on Windows
The
entrytests mockedprocess.cwd()with a POSIX path while the module under test derives the blocks directory withpath.resolve, which is platform-native. On Windows the two never lined up, so the blocks directory prefix was never stripped and every entry name came out as a full absolute path, failing 9 tests on thewindows-latestCI job.Fixtures are now anchored to the same
path.resolvecall as the code under test, so they describe a filesystem that is self-consistent on every platform. Windows path handling additionally gets its own suite that swapspathforpath.win32, so the behaviour is covered on Linux and macOS runs too instead of only when CI happens to run on Windows.Test-only change; no runtime behaviour was modified.
6cb07e6: Fix: leading slashes in asset generation