Repository navigation
fix(ios): batch of eight UX bugs from the onboarding audit - #42
Open
1395490241lhj-code wants to merge 3 commits into
Open
1395490241lhj-code wants to merge 3 commits into
1395490241lhj-code wants to merge 3 commits into
Conversation
- Home: untouched local default recommendations re-rank when the inventory changes; searching, 换一批, removing, opening, adding to today or scrolling past the first card keeps the list. - Quantity boxes (receipt, 添加常备, 生成清单, 使用量) share DecimalQuantityField: writes on every keystroke, a cleared required box falls back to its pre-edit amount, typed text is read as typed, and a pasted grouped amount (1,000) keeps its value. - Inventory: used-up batches no longer count as 已过期/临期 and sink below stocked rows; 缺货 still lists every emptied row per the design language. - Cook confirmation: stock held in one unconvertible unit (1 盒 vs 2 个) can be deducted by hand in that unit; off by default, switched on by typing an amount; undo records unchanged. - Cooking timer: asks for alert+sound permission on first start while undecided (never under UI tests), keeps the due notification on a natural finish, and presents only the timer notification in the foreground. - Weekly result: 加入用餐计划 is the primary action; the missing count and 需要购买 come from the local check behind the dish rows (还缺). - Planned meals tell loading, failed load (with 重试) and a truly missing recipe apart, on Home and in the Planner. - Settings: remove the 完整菜谱库 picker; members who chose it keep full-only plans and favorites resolvable via a read-only lookup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 菜谱库模式 picker is gone and RecipeStore.recipes now also merges the retired full-library dishes kept for former 完整菜谱库 members. Assert the new shape: user recipes still override every library dish by ID, libraryMode is always curated, and Settings no longer offers the picker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes eight deterministic iOS UX bugs found in the onboarding/UX audit. Each was fixed test-first, then reviewed in three rounds (correctness, data safety, UX/accessibility/design), with every finding adversarially verified.
DecimalQuantityFieldfor receipt, 添加常备, 生成清单 and 使用量. It writes on every keystroke. A cleared required box falls back to its pre-edit amount and re-shows it on focus loss. Typed text is read as typed, and a pasted grouped1,000keeps its value.KITCHEN_DESIGN_LANGUAGE.mdPhase A.[.alert, .sound]on first start while undecided, and never under aUITEST_launch. Keeps the due notification on a natural finish.CookingTimerNotificationDelegatepresents only the timer notification in the foreground and is installed in the post-first-frame.task.KitchenButtonStyle; review-and-add-to-shopping is secondary. The count (还缺食材 N 样) and 需要购买 use the local check behind the dish rows, and dish rows now read 还缺 N 样.PlannedRecipeAvailabilitywith loading / failed (重试) / missing states, shared by Home and the Planner viaPlannedMealRecipeDestination.fullkeep a read-only lookup of full-only dishes, so old plans and 收藏/常做 still resolve.docs/IOS_RECIPE_COOKING_MODE.mdis updated for the new timer behaviour.Validation
Run with the
xcodebuildfallback, not Xcode MCP, on Claude's reserved simulator533FDD2Bviadev-sim-slot, with parallel testing off.build-for-testingsucceeded for the app, unit-test and UI-test targets, with no new warnings in changed files.KitchenManagerTestssuite ran 2907 tests: 0 failures, 5 skipped.PR31VisualAcceptanceUITests/testConsumptionSheetExplainsUnitsAndStatusStaplesWeeklyMenuMaterializationUITests/testTheResultNamesTheDaysItCoversAndOffersOneWayToAddThemSettingsExperienceUITests/testCoreSettingsEntriesRemainReachableandtestGuestSettingsLeadsWithAccountStatusAndKeepsLocalUseClearRecipeCookingModeUITests/testCookingTimerCanStartAndCancelWithoutDebugUIRecipeFlowsUITests/testDetailServingsStepsCookingAndEditHomeDashboardUITests/testDecisionModeBrowsesRecommendationsInlineWithoutAnotherNavigationStepandtestAnOrdinaryDayMakesRecipeRecommendationThePrimaryTaskNot verified
Notes / trade-offs
🤖 Generated with Claude Code