Skip to content

feat(openshell): scaffold pinned Agent OS sandbox integration and qualification plan - #435

Closed
rhein1 wants to merge 10 commits into
mainfrom
work/openshell-integration-scaffold-20260928
Closed

rhein1 wants to merge 10 commits into
mainfrom
work/openshell-integration-scaffold-20260928

Conversation

@rhein1

@rhein1 rhein1 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Prepare Agoragentic to use OpenShell as an execution-isolation layer under its existing authority controls. This source-only scaffold validates bounded requests, compiles immutable policy/plan proposals, and projects caller-reported observations without upgrading them to verified receipts.

Cartographer can propose exact-host/path HTTPS GET/HEAD access. Emissary and Steward remain network-denied. Create-time proposals require Landlock, non-root identity and explicit inspected-network enforcement; the fixture command is /bin/true. Invocation always refuses until a real qualified host adapter is supplied. Deadline/resource fields are requirements, not enforced runtime limits.

Upstream is OpenShell v0.1.2 at 6648bd0c290efbc41ba131ee9831ee45cd431f94. The offline CLI, fixture, provenance lock and CODEX_HANDOFF.md document qualification and role-by-role integration. Follow-up lifecycle reconciliation is in #447; private platform work remains tracked in rhein1/agent-marketplace#1896.

Current head e84e0f9 includes the shared CI repairs from #446: compatible dependency fixes, the Windows audit launcher and the freshly reviewed unpublished MatrAIx inventory hold. These prerequisites do not add another PR's feature implementation. Local scaffold tests pass 93/93; machine-surface/count checks, n8n's clean audit and its eight tests pass. Hosted checks on e84e0f9: 52 successful, 0 pending, 0 failed at this update. Required independent approval remains outstanding.

Separate local qualification has built the exact pinned SDK and typechecked the create specification. No live gateway, effective-policy, resource-limit, denial, cancellation or cleanup proof exists. This PR neither connects production role workers nor grants credentials, spend, custody, publication or deployment authority.

The shared hosted MCP repair updates its actual lock and embedded fast-uri implementation to 3.1.8, refreshes ip-address to 10.7.3, and regenerates integrity records and notices. A regression now rejects a lock that disagrees with the advertised, installed and attested dependency. All 16 hosted artifact tests, source/artifact verification, packaging and zero-vulnerability audits pass locally. The bundle remains private and publication-disabled.

Add strict role policy planning, immutable digests, unverified observation
shaping, hard-off adapter, 93 offline tests, qualification handoff, and CI.
No runtime, provider, payment, publication, or production activation.

test('adapter is hard-off regardless of flags, booleans or supplied client', async () => {
let calls = 0;
const adapter = new OpenShellScaffoldAdapter({ enabled: true, client: { create() { calls++; } } });

rhein1 commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

Verification at final scaffold head

Current head: 8be37db95e824da1c00e6028010d26b3c52f7794 (the second commit only appends the OpenShell discovery link to agent-os/README.md; verified as an append-only diff).

  • Local Node v22.16.0: 93 passed, 0 failed, 0 skipped; syntax checks, fixture preview, and readiness command also pass.
  • The seven committed scaffold file Git blob IDs match the locally tested bytes exactly.
  • OpenShell offline scaffold CI passed all four jobs on this head: Ubuntu/Windows x Node 20/22. Run: https://github.com/rhein1/agoragentic-integrations/actions/runs/36498589996
  • Validate Machine Surfaces and CodeQL were still in progress at the latest check. This comment does not claim that all required repository checks are green.

Nine files changed in this PR: eight new scaffold/CI files plus the parent README discovery link. No existing implementation was removed.

This remains a draft, unmerged, source-only preparation PR. No OpenShell SDK/gateway runtime, generated-type conformance, real image, containment, provisioning, resource enforcement, live role execution, or production qualification is claimed.

rhein1 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

September 29 dependency-status update

The earlier final-head note said broader checks were still running. Their inspected results are now: OpenShell targeted workflow passed, CodeQL passed, and Validate Machine Surfaces failed at Validate MCP package on head 8be37db95e824da1c00e6028010d26b3c52f7794. Later validation steps were skipped. Do not treat this PR as fully green or runtime-qualified.

Related governed harness-evolution preparation is now in #436, with the Codex implementation owner task at rhein1/fable5-codex#24 . It treats this OpenShell scaffold as optional and unqualified, not as already installed isolation. No branch merge, production activation or financial authority follows from that linkage.

The new #436 run also failed in the MCP package step; its inspected log identifies an ip-address npm audit finding after all 58 MCP tests passed. See #436's final verification comment for the exact failure evidence and separately scoped remediation instructions. That diagnosis must be confirmed against this PR's own log before assuming identical root cause here.

@rhein1
rhein1 marked this pull request as ready for review October 1, 2026 23:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T23:40:48.599971Z 2c894dd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rhein1 rhein1 closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants