Repository navigation
feat(openshell): reconcile lifecycle failures and cleanup observations offline - #447
Conversation
Add strict role policy planning, immutable digests, unverified observation shaping, hard-off adapter, 93 offline tests, qualification handoff, and CI. No runtime, provider, payment, publication, or production activation.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent read-only refresh review at 82864dd, including its composition with current main b30a3de: no source findings. Local Node24 compiler suite 93/93 and lifecycle suite 17/17 passed with zero skips. Readiness continues to report activationSupported:false and liveTrafficProtected:false. All52 hosted checks pass and no review conversation remains unresolved; required independent GitHub approval is still missing. The owner-recorded isolated Blackbox CLI lab does not establish the authenticated SDK-to-host observation bridge, effective enforcement or production qualification for this offline adapter. Invocation remains disabled. Review trace: worker /root/openshell_review, read-only source/callers, lifecycle/idempotency, policy/authority and documentation lenses; no recursive delegation or external runtime actions. |
Retain the 11 reviewed OpenShell feature paths unchanged. Preserve current main for all shared manifests, dependency closures, hosted artifacts, authentication, SkillSpector admission, and durable worker/handle code. OpenShell invocation remains hard-off. Timeout and caller-reported cleanup do not establish worker termination or verified live cleanup.
jmborden1112-beep
left a comment
jmborden1112-beep
left a comment
There was a problem hiding this comment.
LGTM
Needs Fixing
None. Fixed the confirmed POSIX FIFO preview hang using nonblocking open flags while retaining fd-based regular-file rejection and bounded input. The meaningful no-writer FIFO subprocess regression actually passed on Linux; scaffold94/94 and adapter17/17. Windows scaffold93passed/1expectedPOSIXskip and adapter17/17. /root/integrations_stack_review plus root verification, gpt-6-luna medium fallback. Current-main RRSI and governance additions were already reviewed/validated separately; OpenShell source files are unchanged after their merge. Adapter stays hard-off with no host activation.
Requires Human Review
None beyond the repository approval gate fulfilled under the owner's second-account authorization. This is agent source review, not independent human sign-off.
Recommended Optional
None.
Create Follow-up Issue
None.
Workflow Trace: exact head a16024c, 12 successful final-head hosted checks. No live models, provider calls, payment, production activation, or publication.
Extend #435 with an offline OpenShell lifecycle reconciler. It binds reported events to the exact plan and original sandbox ID, rejects invalid ordering and unsafe retries, retains late identities for cleanup, requires terminal exit codes, and preserves cancellation, timeout, revocation and pending/unknown deletion. Caller reports never become verified runtime evidence.
The branch includes #435 and shared CI prerequisites #444/#446. Current head 82864dd includes the shared dependency/audit/inventory repairs and rebuilt hosted MCP bundle; its OpenShell feature source is unchanged. Local compiler/lifecycle tests pass 110/110 with zero skips; machine-surface/count checks and n8n audit/tests pass. Hosted checks on 82864dd: 52 successful, 0 pending, 0 failed when refreshed on October 3, 2026. Required independent approval remains outstanding.
Separate qualification built the pinned OpenShell v0.1.2 SDK and typechecked the create specification. The owning workstream subsequently recorded isolated Blackbox VM authentication, resource-limit, file-access, network allow/deny, and cleanup observations in implementation issue #1896. Those lab observations do not qualify this offline reconciler's missing authenticated observation bridge or connect production workers. Invocation remains hard-off; the real authenticated SDK-to-host observation bridge, effective policy, actual limits, cancellation and cleanup still require a disposable approved environment. Cartographer, Emissary and Steward are not connected, and no provider, credential, spend or production authority is granted.
The shared hosted MCP repair updates its actual lock and embedded fast-uri implementation to 3.1.8, refreshes ip-address to 10.7.3, and regenerates integrity records and notices. A regression now rejects a lock that disagrees with the advertised, installed and attested dependency. All 16 hosted artifact tests, source/artifact verification, packaging and zero-vulnerability audits pass locally. The bundle remains private and publication-disabled.