Repository navigation
fix(render): draw the pneumatic hatch from HATCH_ARM and drop Port.side - #573
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the last two of the nine dead declarations #304 lists.
HATCH_ARM: it named the pneumatic hatch stroke's reach, but neither backend read it. The SVG renderer drew the strokes from bare numbers, and the draw.io exporter hard-coded an angle and length while citingHATCH_ARMas their source. Both now take the stroke from it.Port.side: never passed and never read; it is removed.No drawing changes.
Related Issues
Closes #304
The other seven names were removed earlier:
Pin.is_fixed_xy,Pin.has_grid,Route.lane,_CHAR_Wand_LINE_Hin b838106;X_GAPandY_GAPin c45fcc0 (feat(layout): place a unit from the faces its nozzles are fixed to (#431) #442), where the column gap became the namedCOL_GAP.Changes
pandid/render/svg.py: the pneumatic hatch strokes are built fromHATCH_ARM(half-reach along and across the run) instead of the literals3and5.HATCH_ARMhas its own doc comment.pandid/render/drawio.py:_HATCH_ANGLEand_HATCH_LENare derived fromHATCH_ARMusingatan2andhypot, and rounded to two places, so they come out as the same -59.04 and 11.66.pandid/ports.pyandpandid/units.py: removePort.sideand the unusedsideparameter ofUnit._add_port.tests/test_drawio.py:HATCH_ARM; it fails onmain;CHANGELOG.md: a "Changed" entry for the hatch and a "Removed" entry forPort.side.API note:
Portis exported, andsideis removed without a deprecation release, as b838106 did for the earlier names. Code that readport.side(alwaysNone) or built aPortwithside=will break. Nothing in the package, examples, docs or scripts does either.How to Test
Evidence
main. Eight of them draw pneumatic hatches: 04, 08, 11, 14, 15, 17, 18 and 20.mainfor 46 drawings (the 21 examples as authored and with placement stripped, plus four benchmark sheets).git diff --checkare clean;pandid/plus the existing__all__warning;tests/test_drawio.pykeeps its 240 existing diagnostics (tests/ carries 1044 pyright diagnostics, so the pyright CI gate covers pandid/ only #530); none were added.Checklist
mainand the branch is mergeable🤖 Generated with Claude Code