Repository navigation
docs: document usage and billing data privacy - #503
Merged
Merged
Conversation
|
@Ramino2406 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the privacy properties of usage data that the application actually stores today. The existing observability guide describes a proposed ledger, so explicitly label that design and distinguish its content-free requirement from current conversation storage.
Linked issue
Closes #488
Changes
Validation
pytestfully green: 2,246 passed, 2 failed across all 123 test files (Python 3.12.15; four normal pytest batches).ruff check .passes.black --check .passes (263 files unchanged).python scripts/check_assets.pypasses.git diff --checkand relative source-link checks pass.0e37c6d; missing ledger APIs/configuration explicitly identified.Notes for reviewers
There is no implemented standalone usage/billing ledger in this revision. This documentation does not introduce one or promise an unenforced retention policy. When the Phase 10 ledger lands, the guide should be updated against its actual schema and cleanup/access controls. No dependencies or application code changed.
Existing test failures and CI
Both failures are in
tests/test_notifications.py::TestBudgetAlertDeduplication:test_repeated_crossings_alert_once_per_periodtest_new_period_resets_deduplicationBoth raise
ModuleNotFoundError: No module named 'app.services.budget_alerts'. The imported module is absent from upstreammainat0e37c6d, and this branch changes neitherapp/nortests/. These are baseline failures, not introduced by this documentation change.The full sequential run was slow on Windows, and pytest-xdist hit a Windows WMI startup exception before executing tests. Verification therefore used four independent normal pytest processes, assigning every
tests/test_*.pyfile once in sorted round-robin order:python -m pytest -p no:xdist --durations=5 <batch files>. Batch results: 509 passed; 629 passed; 559 passed; 549 passed / 2 failed. The temporary parallel-runner tooling is outside the repository; no dependencies changed.Upstream CI run reports
action_requiredand awaits maintainer approval; no CI pass is claimed.