Repository navigation
[MrBot] Require C++17 in default build options - #471
Open
Abhinandan Sharma (abhinandan-codes) wants to merge 3 commits into
Open
Abhinandan Sharma (abhinandan-codes) wants to merge 3 commits into
Abhinandan Sharma (abhinandan-codes) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
/azp run Azure-C-Build-Tools-Gate |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
/azp run Azure-C-Build-Tools-Gate |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
| if (NOT DEFINED CMAKE_CXX_STANDARD OR CMAKE_CXX_STANDARD LESS 17) | ||
| set(CMAKE_CXX_STANDARD 17) | ||
| endif() | ||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) |
There was a problem hiding this comment.
Is this change validated on all repos that it passes the gate?
Sounds like something that has chances of failing down the pipeline - in EBS/ELS.
Let's make draft PRs with this SHA just to make sure we pass gates before we push it.
| #use _CRT_SECURE_NO_WARNINGS by default | ||
| add_definitions(-D_CRT_SECURE_NO_WARNINGS) | ||
|
|
||
| # C-facing dependency headers still include <cstdbool>, which MSVC deprecates in C++17. |
Collaborator
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
/azp run Azure-C-Build-Tools-Gate |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
This was referenced Oct 21, 2026
Draft
Author
|
/azp run Azure-C-Build-Tools-Gate |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require at least C++17 in
set_default_build_options()for all C++ targets, including tests, while preserving a newer caller-selected standard.Prerequisites that remove deprecated
<cstdbool>/<cstdalign>includes from C++ code: Azure/c-pal#653, zrpc !17611682, Azure-MessagingStore !17611683, Azure-Messaging-GeoReplication !17611684.