Repository navigation
[MrBot] Stop including deprecated C compatibility headers in C++ - #653
Open
Abhinandan Sharma (abhinandan-codes) wants to merge 1 commit into
Open
Abhinandan Sharma (abhinandan-codes) wants to merge 1 commit into
Abhinandan Sharma (abhinandan-codes) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Oct 21, 2026
| #else | ||
| #ifndef __cplusplus | ||
| #include <stdbool.h> | ||
| #endif |
Contributor
There was a problem hiding this comment.
I think we should keep it as:
#ifdef __cplusplus
#else
#include <stdbool.h>
#endif
That's our typical convention, which means less churn if new headers are added
| #else | ||
| #ifndef __cplusplus | ||
| #include <stdbool.h> | ||
| #endif |
Contributor
There was a problem hiding this comment.
Same comment
#ifdef __cplusplus
#else
#include <stdbool.h>
#endif
Contributor
There was a problem hiding this comment.
here and everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
<cstdbool>and<cstdalign>from the C++ branch of public and reals headers.bool,alignasandalignofare C++ keywords, and these headers are deprecated in C++17 (MSVC STL4004), which fails/WXbuilds. C translation units still include<stdbool.h>/<stdalign.h>.Prerequisite for raising the default C++ standard to C++17 in Azure/c-build-tools#471.