Skip to content

[MrBot] Stop including deprecated C compatibility headers in C++ #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhinandan Sharma (abhinandan-codes) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MrBot] Stop including deprecated C compatibility headers in C++ #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion c_pal_ll/interfaces/reals/real_sync.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#define REAL_SYNC_H

#ifdef __cplusplus
#include <cstdbool>
#include <cstdint>
#else
#include <stdbool.h>
Expand Down
1 change: 0 additions & 1 deletion interfaces/inc/c_pal/malloc_multi_flex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#ifdef __cplusplus
#include <cstddef>
#include <cstdint>
#include <cstdalign>
#else
#include <stddef.h>
#include <stdint.h>
Expand Down
4 changes: 1 addition & 3 deletions interfaces/inc/c_pal/srw_lock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
#ifndef SRW_LOCK_H
#define SRW_LOCK_H

#ifdef __cplusplus
#include <cstdbool>
#else
#ifndef __cplusplus
#include <stdbool.h>
#endif

Expand Down
4 changes: 1 addition & 3 deletions interfaces/inc/c_pal/srw_lock_ll.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
#ifndef SRW_LOCK_LL_H
#define SRW_LOCK_LL_H

#ifdef __cplusplus
#include <cstdbool>
#else
#ifndef __cplusplus
#include <stdbool.h>
#endif

@mattdurak Matt Durak (mattdurak) Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it as:

#ifdef __cplusplus
#else
#include <stdbool.h>
#endif

That's our typical convention, which means less churn if new headers are added


Expand Down
2 changes: 0 additions & 2 deletions interfaces/inc/c_pal/uuid.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

#ifdef __cplusplus
#include <cinttypes>
#include <cstdbool>
#include <cstdalign>
#else
#include <inttypes.h>
#include <stdbool.h>
Expand Down
4 changes: 1 addition & 3 deletions interfaces/reals/real_srw_lock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
#ifndef REAL_SRW_LOCK_H
#define REAL_SRW_LOCK_H

#ifdef __cplusplus
#include <cstdbool>
#else
#ifndef __cplusplus
#include <stdbool.h>
#endif

@mattdurak Matt Durak (mattdurak) Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

#ifdef __cplusplus
#else
#include <stdbool.h>
#endif

@mattdurak Matt Durak (mattdurak) Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here and everywhere


Expand Down
4 changes: 1 addition & 3 deletions interfaces/reals/real_srw_lock_ll.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
#ifndef REAL_SRW_LOCK_LL_H
#define REAL_SRW_LOCK_LL_H

#ifdef __cplusplus
#include <cstdbool>
#else
#ifndef __cplusplus
#include <stdbool.h>
#endif

Expand Down
4 changes: 1 addition & 3 deletions interfaces/reals/real_string_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
#ifndef REAL_STRING_UTILS_H
#define REAL_STRING_UTILS_H

#ifdef __cplusplus
#include <cstdbool>
#else
#ifndef __cplusplus
#include <stdbool.h>
#endif

Expand Down
Loading