Repository navigation
Make UI not fully fail to initialise for single Item throwing exception - #568
Merged
IsakNaslundBh merged 2 commits intoSep 16, 2026
Conversation
Also requiring additional nullfiltering to avoid adding nulls to the list
IsakNaslundBh
requested review from
Kar-Myl,
pawelbaran and
peterjamesnugent
September 16, 2026 07:56
Contributor
Author
|
@BHoMBot check installer |
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
Contributor
Author
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
peterjamesnugent
approved these changes
Sep 16, 2026
peterjamesnugent
left a comment
peterjamesnugent
left a comment
Member
There was a problem hiding this comment.
Tested using the provided installer - error is caught successfully (by calling AllEvents() and FilterByProperty to see EventType.Error and importantly the UI does not fail to load.
Member
|
@BHoMBot check ready-to-merge |
|
@peterjamesnugent to confirm, the following actions are now queued:
There are 21 requests in the queue ahead of you. |
IsakNaslundBh
deleted the
BHoM_UI-#567-ProtectAgainstSingleFailingCodeItemCausingFullFailureOfUILoad
branch
September 16, 2026 10:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #567
Try-catch blocks on CodeElement methods
Also requiring additional nullfiltering to avoid adding nulls to the list
Test files
See BHoM/BHoM_Engine#3614 for example method to test with.
Test by adding the method to one of the Engines in the BHoM_Engine. Preferably a discipline engine (like structures or similar) that is not directly used by grasshopper. After rebuilding with BHoM_UI on develop (before this fix) you should get full load failure on the UI side when initialising grasshopper/excel.
Then rebuild BHoM_UI on this branch, and if testing with Grasshopper then you also need to rebuild Grasshopper_UI. After that the BHoM should load, and you should find a record in the startup events stating that the method failed to initialise.
Changelog
Additional comments