Skip to content

Make UI not fully fail to initialise for single Item throwing exception #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IsakNaslundBh merged 2 commits into from
Sep 16, 2026
Merged

Make UI not fully fail to initialise for single Item throwing exception #568

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22424c7
Try-catch blocks on CodeElement methods
IsakNaslundBh Sep 16, 2026
ba38a19
Record assembly as well
IsakNaslundBh Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 67 additions & 37 deletions UI_Engine/Query/CodeElements.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,30 +54,36 @@ public static List<CodeElementRecord> CodeElements()

// All constructable BHoM objects and requests
items.AddRange(BH.Engine.UI.Query.ConstructableTypeItems()
.Select(x => CodeElement(x, GetConstructableType(x), x.ConstructorText())));
.Select(x => CodeElement(x, GetConstructableType(x), x.ConstructorText()))
.Where(x => x != null));

// All Enums
items.AddRange(BH.Engine.UI.Query.EnumItems()
.Select(x => CodeElement(x, CodeElementType.Enum, x.ToText(true))));
.Select(x => CodeElement(x, CodeElementType.Enum, x.ToText(true)))
.Where(x => x != null));

// All Types
items.AddRange(BH.Engine.UI.Query.TypeItems()
.Select(x => CodeElement(x, CodeElementType.Type, x.ToText(true))));
.Select(x => CodeElement(x, CodeElementType.Type, x.ToText(true)))
.Where(x => x != null));

/// Methods

// All adapter constructors
items.AddRange(BH.Engine.UI.Query.AdapterConstructorItems()
.Select(x => CodeElement(x, CodeElementType.AdapterConstructor, x.ToText(true))));
.Select(x => CodeElement(x, CodeElementType.AdapterConstructor, x.ToText(true)))
.Where(x => x != null));

// All methods for the BHoM Engine (including creators)
items.AddRange(BH.Engine.Base.Query.BHoMMethodList()
.Where(x => x.IsExposed())
.Select(x => CodeElement(x, GetMethodType(x), x.ToText(includePath: true, removeIForInterface: false))));
.Select(x => CodeElement(x, GetMethodType(x), x.ToText(includePath: true, removeIForInterface: false)))
.Where(x => x != null));

// All methods from external class
items.AddRange(BH.Engine.UI.Query.ExternalItems()
.Select(x => CodeElement(x, CodeElementType.Method_External, x.ToText(true))));
.Select(x => CodeElement(x, CodeElementType.Method_External, x.ToText(true)))
.Where(x => x != null));

// Return the list
return items;
Expand All @@ -90,45 +96,69 @@ public static List<CodeElementRecord> CodeElements()

private static CodeElementRecord CodeElement(Type type, CodeElementType elementType, string displayText)
{
List<Type> inputTypes = type.GetProperties()
.Select(x => x.PropertyType?.UnderlyingType()?.Type)
.Where(x => x != null)
.Distinct()
.ToList();

return new CodeElementRecord
try
{
List<Type> inputTypes = type.GetProperties()
.Select(x => x.PropertyType?.UnderlyingType()?.Type)
.Where(x => x != null)
.Distinct()
.ToList();

return new CodeElementRecord
{
AssemblyName = AssemblyName(type),
AssemblyModifiedTime = AssemblyModifiedTime(type),
Type = elementType,
DisplayText = displayText,
Json = type.ToJson(),
InputKeys = inputTypes.Select(x => x.ToText(true)).ToList(),
OutputKeys = type.UnderlyingType()?.Type.OutputKeys()
};
}
catch (Exception e)
{
AssemblyName = AssemblyName(type),
AssemblyModifiedTime = AssemblyModifiedTime(type),
Type = elementType,
DisplayText = displayText,
Json = type.ToJson(),
InputKeys = inputTypes.Select(x => x.ToText(true)).ToList(),
OutputKeys = type.UnderlyingType()?.Type.OutputKeys()
};
if (type == null) //Don't think this will ever happen, but adding as a extra safeguard
BH.Engine.Base.Compute.RecordError(e, "Null type found when initialising the UI.");
else
BH.Engine.Base.Compute.RecordError(e, $"Failed to load type {type.FullName} from {type.Assembly.FullName} to the BHoM UI. The type will not be available.");

return null;
}
}

/*************************************/

private static CodeElementRecord CodeElement(MethodBase method, CodeElementType elementType, string displayText)
{
Type outputType = (method is MethodInfo) ? ((MethodInfo)method).ReturnType : method.DeclaringType;
List<Type> inputTypes = method.GetParameters()
.Select(x => x.ParameterType?.UnderlyingType()?.Type)
.Where(x => x != null)
.Distinct()
.ToList();

return new CodeElementRecord
try
{
Type outputType = (method is MethodInfo) ? ((MethodInfo)method).ReturnType : method.DeclaringType;
List<Type> inputTypes = method.GetParameters()
.Select(x => x.ParameterType?.UnderlyingType()?.Type)
.Where(x => x != null)
.Distinct()
.ToList();

return new CodeElementRecord
{
AssemblyName = AssemblyName(method),
AssemblyModifiedTime = AssemblyModifiedTime(method),
Type = elementType,
DisplayText = displayText,
Json = method.ToJson(),
InputKeys = inputTypes.Select(x => x.ToText(true)).ToList(),
OutputKeys = outputType.UnderlyingType()?.Type.OutputKeys()
};
}
catch (Exception e)
{
AssemblyName = AssemblyName(method),
AssemblyModifiedTime = AssemblyModifiedTime(method),
Type = elementType,
DisplayText = displayText,
Json = method.ToJson(),
InputKeys = inputTypes.Select(x => x.ToText(true)).ToList(),
OutputKeys = outputType.UnderlyingType()?.Type.OutputKeys()
};
if(method == null) //Don't think this will ever happen, but adding as a extra safeguard
BH.Engine.Base.Compute.RecordError(e, "Null method found when initialising the UI.");
else
BH.Engine.Base.Compute.RecordError(e, $"Failed to load method {method.Name} from {method.DeclaringType.FullName} from assembly {method.DeclaringType.Assembly.FullName} to the BHoM UI. The method will not be available.");

return null;
}
}

/*************************************/
Expand Down
Loading