Skip to content

Use the normal SimpleAPI artifact - #323

Merged
BenCodez merged 3 commits into
masterfrom
codex/coordinated-jar-size
Sep 13, 2026
Merged

BenCodez merged 3 commits into
masterfrom
codex/coordinated-jar-size

Conversation

@BenCodez

@BenCodez BenCodez commented Sep 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • consume SimpleAPI's normal artifact after the temporary thin classifier was removed
  • preserve AdvancedCore's established transitive dependency/publication contract
  • leave final distribution filtering to VotingPlugin
  • retain package-phase checks for required classes and relocations

This deliberately does not optimize AdvancedCore's JAR independently; the user-facing VotingPlugin download remains optimized by VotingPlugin's own artifact filters.

Validation

  • mvn -B -f AdvancedCore/pom.xml clean install
    • 332 ordinary tests passed
    • packaged-artifact test passed
  • merged VotingPlugin #1606 built against the installed candidate
    • 623 ordinary tests passed
    • packaged-artifact test passed
  • AdvancedCore JAR opens successfully: 4,492,416 bytes, SHA-256 e8d8fd98bb65334c043ca2488d3a9fdf14b020d4e6f0c58debd0689e6a100bd9
  • VotingPlugin JAR remains 8,576,681 bytes and excludes duplicate Rhino and unused HTTP crypto
  • git diff --check
  • fresh independent frozen-diff review: No findings.

No artifact was published and no deployment was performed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-13T00:15:11.342685Z fd50e81 New commits
🔒 Security Review ✅ Completed 2026-09-12T23:58:03.112322Z 2a1ed4f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a1ed4ffd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AdvancedCore/pom.xml Resolved
@BenCodez BenCodez changed the title Filter embedded optional dependencies Use the normal SimpleAPI artifact Sep 13, 2026
@BenCodez
BenCodez merged commit 8b5b909 into master Sep 13, 2026
4 checks passed
@BenCodez
BenCodez deleted the codex/coordinated-jar-size branch September 13, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant