Skip to content

Use the normal SimpleAPI artifact #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenCodez merged 3 commits into from
Sep 13, 2026
Merged

Use the normal SimpleAPI artifact #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a1ed4f
Filter embedded optional dependencies
BenCodez Sep 12, 2026
52f9242
Keep embedded SimpleAPI non-transitive
BenCodez Sep 13, 2026
fd50e81
Preserve the AdvancedCore dependency contract
BenCodez Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion AdvancedCore/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@
<groupId>com.bencodez</groupId>
<artifactId>simpleapi</artifactId>
<version>1.0.2-SNAPSHOT</version>
<classifier>thin</classifier>
<scope>compile</scope>
<exclusions>
<exclusion>
Expand Down
11 changes: 2 additions & 9 deletions ...cedCore/src/test/java/com/bencodez/advancedcore/tests/packaging/PackagedArtifactTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.bencodez.advancedcore.tests.packaging;

import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
Expand All @@ -15,7 +14,7 @@
public class PackagedArtifactTest {

@Test
void keepsRequiredRelocatedLibrariesWithoutOptionalTransports() throws Exception {
void keepsRequiredClassesAndRelocations() throws Exception {
Path artifactPath = packagedJar();
try (JarFile artifact = new JarFile(artifactPath.toFile())) {
assertNotNull(artifact.getEntry("com/bencodez/advancedcore/AdvancedCorePlugin.class"));
Expand All @@ -27,14 +26,8 @@ void keepsRequiredRelocatedLibrariesWithoutOptionalTransports() throws Exception
assertNull(artifact.getEntry("com/tcoded/folialib/FoliaLib.class"));
assertNull(artifact.getEntry("com/zaxxer/hikari/HikariDataSource.class"));
assertNull(artifact.getEntry("org/mozilla/javascript/Context.class"));
assertFalse(artifact.stream().anyMatch(entry -> entry.getName().startsWith("org/bouncycastle/")));
assertFalse(artifact.stream().anyMatch(entry -> entry.getName()
.startsWith("com/bencodez/simpleapi/servercomm/http/")));
assertFalse(artifact.stream().anyMatch(entry -> entry.getName().startsWith("redis/clients/")));
assertFalse(artifact.stream().anyMatch(entry -> entry.getName().startsWith("org/eclipse/paho/")));
assertFalse(artifact.stream().anyMatch(entry -> entry.getName().startsWith("META-INF/versions/25/")));
}
System.out.printf("AdvancedCore packaged artifact: %,d bytes; optional HTTP/Redis/MQTT payload absent%n",
System.out.printf("AdvancedCore packaged artifact: %,d bytes; required classes and relocations retained%n",
Files.size(artifactPath));
}

Expand Down
15 changes: 9 additions & 6 deletions docs/jar-packaging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# JAR packaging contract

AdvancedCore consumes SimpleAPI's `thin` classifier so Maven Shade sees the
project classes and each dependency exactly once. The normal SimpleAPI artifact
remains a self-contained compatibility artifact for other consumers.
AdvancedCore consumes SimpleAPI's normal self-contained artifact for SNAPSHOT
compatibility and preserves the established transitive dependency contract.
It does not add an AdvancedCore-specific payload filter or change dependency
publication semantics for existing consumers.

AdvancedCore does not use SimpleAPI's HTTP, Redis, or MQTT implementations.
Its SimpleAPI dependency therefore excludes Bouncy Castle, Jedis, and Paho.
Expand All @@ -15,6 +16,8 @@ that contain Gson types, while the supported server/proxy platforms supply it.
Rhino remains bundled and relocated for the JavaScript feature.

The package phase runs `PackagedArtifactTest` after shading. It verifies the
actual minimized JAR contains required relocated classes and no HTTP crypto,
Redis, MQTT, or Java 25 Bouncy Castle payload. Deployment profiles use the same
Shade configuration; only publication/final-name behavior differs.
actual minimized JAR contains its required classes and relocations. VotingPlugin
applies its own narrow artifact filters when producing its smaller user-facing
distribution.
Deployment profiles use the same Shade configuration; only
publication/final-name behavior differs.
Loading