Skip to content

Improve the Full YAML configuration workbench - #20

Merged
BenCodez merged 2 commits into
mainfrom
codex/control-mockup-foundation-20260927
Sep 28, 2026
Merged

BenCodez merged 2 commits into
mainfrom
codex/control-mockup-foundation-20260927

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Summary

  • document the approved nine-page mockup set against current Control/VotingPlugin capabilities
  • add a focused Full YAML workbench module with synchronized line numbers, bounded find navigation, cursor/document metrics, and explicit source/revision identity
  • distinguish confirmed live reads, snapshot drafts, unsaved edits, loading, and no-document states
  • keep all edits on the existing redacted, revision-aware READ -> PREVIEW -> APPROVE -> APPLY -> confirmed READ workflow

Reality boundary

The new capability map classifies each major mockup element as already real, implementable, future/unsupported, or mockup-only/invalid. It explicitly avoids claims for CPU/RAM, website uptime, Votifier port reachability, generic database health, guaranteed reward execution health, arbitrary update URLs, or analytics that current retained evidence cannot support.

This PR does not add a connector capability or change VotingPlugin behavior. It does not expose, store, search outside the browser, or otherwise change handling of redacted secrets. Snapshot content is labeled as a draft and retains its actual source-node identity rather than being shown as a confirmed current read.

Validation

  • node --check src/main/resources/web/app.js
  • node --check src/main/resources/web/yaml-editor.js
  • node --test src/test/web/*.test.cjs — 113 passed, 0 failed/skipped
  • mvn -B clean verify — 277 passed, 0 failed/errors/skipped
  • git diff --check
  • packaged shaded JAR contains web/yaml-editor.js
  • shaded JAR: 3,266,703 bytes
  • SHA-256: 16a1603bc706164f5a6d86c4554a6ba883d130e6305ce7908e2a43a3c3573fc5

Review

A final direct base-to-head source review found one truthfulness issue: restored snapshots were initially presented like confirmed reads and could show the selected target rather than the snapshot document source. The final implementation labels them Snapshot draft and shows the actual source node. No remaining correctness findings were found.

Follow-up sequence

  1. align Network Health and Setup Doctor navigation/layout while retaining observed/unknown evidence semantics
  2. expand typed configuration from current VotingPlugin defaults/loaders, keeping Full YAML available
  3. expand supported reward structures
  4. investigate the real allowlisted bencodez.com build source before adding build discovery
  5. add semantic drift, typed backups, bounded analytics, and redacted report bundles through additive capabilities

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 50fc263d-4c77-4ea0-af58-d1b79b050afb


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T23:07:55.708970Z 8d4dc14 New commits
🔒 Security Review ✅ Completed 2026-09-28T03:32:11.012140Z 999c4ad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 999c4add06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/resources/web/yaml-editor.js Resolved
Comment thread src/main/resources/web/app.js Resolved
Comment thread src/main/resources/web/app.css Resolved
@BenCodez
BenCodez force-pushed the codex/control-mockup-foundation-20260927 branch from 999c4ad to 15d8c08 Compare September 28, 2026 03:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15d8c085a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/resources/web/app.js Resolved
@BenCodez
BenCodez merged commit fef60b4 into main Sep 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant