Skip to content

Stop showing formatting guards in NeoForge vote-site messages - #1705

Closed
BenCodez wants to merge 3 commits into
masterfrom
fix/inert-votesite-display-boundaries-20261011
Closed

BenCodez wants to merge 3 commits into
masterfrom
fix/inert-votesite-display-boundaries-20261011

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Problem

WORD JOINER (U+2060) guards added by #1643 are necessary to keep external site identifiers inert during templating, but Minecraft may render them as unsupported glyphs.

Fix

  • Preserve ServiceSiteValidator.inertForFormatting(...) and exact, raw service identifiers.
  • Add a clearly-scoped terminal cleanup helper; call it only after validating and expanding a NeoForge message, immediately before Component.literal(...).
  • Add regression tests for normal, color-like, placeholder-like, ampersand-bearing and URL-like vote site values.

Cross-repository dependencies

The Bukkit/Paper display paths are addressed in SimpleAPI#112 (dialogs/action bars) and AdvancedCore#362 (inventory, book, chat, titles and boss bars). Those libraries are shaded into VotingPlugin; no change to administrator configs or exact reward-action arguments is intended.

Validation

CI package/test run and a cross-library integration build are required; Maven is unavailable in the current editing environment. Leave as draft until all dependencies pass. No merge requested.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2cf1b9ff-48f6-4dc3-abcc-67956c375a26

📥 Commits

Reviewing files that changed from the base of the PR and between 3b1994c and dec96b7.


📒 Files selected for processing (3)
  • VotingPlugin/src/main/java/com/bencodez/votingplugin/neoforge/NeoForgeNativeRewardActions.java
  • VotingPlugin/src/main/java/com/bencodez/votingplugin/util/ServiceSiteValidator.java
  • VotingPlugin/src/test/java/com/bencodez/votingplugin/tests/ServiceSiteValidatorTest.java

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant