Skip to content

Fix Windows cleanup in deleted-mail recovery tests - #36

Merged
mrinc merged 1 commit into
masterfrom
fix/windows-recovery-test-cleanup
Oct 4, 2026
Merged

mrinc merged 1 commit into
masterfrom
fix/windows-recovery-test-cleanup

Conversation

@bcbetterninja

@bcbetterninja bcbetterninja commented Oct 4, 2026 •

Copy link
Copy Markdown
Collaborator

Windows checks and the master build failed after the two legacy deleted-mail recovery cases completed their assertions: cleanup could not delete mail.db because the direct SQLite fixture connection remained pooled after disposal.

Disable pooling on that temporary legacy-payload writer so disposal releases its file handle before the encrypted test database is removed.

Validation: solution build passed with zero warnings/errors; all 12 deleted-mail recovery regression cases passed locally. Windows, Linux, macOS and CodeQL checks passed, including the full 579-test suite on Windows.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b4a42fad-b817-4efb-8d17-90f31d0539ff
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mrinc
mrinc merged commit 3b27160 into master Oct 4, 2026
9 checks passed
@mrinc
mrinc deleted the fix/windows-recovery-test-cleanup branch October 4, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants