Repository navigation
fix(token-item): resolve button nesting hydration error - #210
Merged
Merged
Conversation
Use render prop on DropdownMenuTrigger to delegate rendering to Button component, following shadcn/ui + base-ui best practices. This avoids nesting <button> elements which causes React hydration errors.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
首页启动时出现 React hydration 错误:
错误堆栈显示
TokenItem > Item > DropdownMenuTrigger > Button > button嵌套。Root Cause
DropdownMenuTrigger基于@base-ui/react/menu的Menu.Trigger,默认渲染为<button>。而内部又放了一个<Button>组件,导致嵌套的<button>元素。Solution
遵循 shadcn/ui + base-ui 最佳实践,使用
render属性将渲染委托给Button组件:Testing