Repository navigation
feat(transfer): add pay password support for BioForest Chain - #95
Merged
Merged
Conversation
- Add setPayPassword, createSignatureTransaction, getSignatureTransactionMinFee to SDK - Create SetPayPasswordJob sheet for setting pay password UI - Add submitSetPayPassword, getSetPayPasswordFee, hasPayPasswordSet helpers - Add i18n translations for pay password UI (zh-CN, en) - Create e2e test for BioForest transfer flow - Add API test script for debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds pay password (二次签名/second signature) support for BioForest Chain transfers.
Changes
SDK Enhancements (
src/services/bioforest-sdk/index.ts)setPayPassword- Create and broadcast signature transaction to set pay passwordcreateSignatureTransaction- Create signature transaction using SDKgetSignatureTransactionMinFee- Get minimum fee for setting pay passwordNew UI Component (
SetPayPasswordJob.tsx)Helper Functions (
use-send.bioforest.ts)submitSetPayPassword- Full flow to set pay passwordgetSetPayPasswordFee- Get fee for setting pay passwordhasPayPasswordSet- Check if address has pay passwordi18n
Testing
Testing Notes
The network API was not reachable during development (proxy issues), but all TypeScript types check and unit tests pass. Real network testing should be done when network access is restored.
Related Issues