Keep Vulkan loader in Inno libmpv bundle - #19
Draft
Blackspirits wants to merge 1 commit into
Draft
Conversation
|
@Blackspirits Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; validation passed.
Pull request overview
Adds vulkan-1.dll to the Windows Inno installer alongside libmpv-2.dll.
Changes:
- Packages the Vulkan loader from the verified libmpv bundle.
- Installs it in the application data directory.
File summaries
| File | Summary |
|---|---|
installer/WindowsInno/Subtitle_Edit_Installer.iss |
Includes vulkan-1.dll in the installer. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows ZIP copies the complete verified libmpv bundle, including
vulkan-1.dll, but the Inno staging/installer includes onlylibmpv-2.dll.This change adds
vulkan-1.dllfrom the same verified libmpv bundle to the Inno installer besidelibmpv-2.dll.Validation
libmpv-2.dllandvulkan-1.dllin the verified bundleAI assistance: ChatGPT was used to audit the packaging path and prepare this one-file fix.