Keep Vulkan loader in Inno libmpv bundle - #69
Draft
Blackspirits wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows ZIP packages copy the complete verified libmpv bundle, including
vulkan-1.dll, because the current libmpv build imports the Vulkan loader at load time. The Inno installer staging still installs onlylibmpv-2.dll, so the installer package drops a dependency that the ZIP path preserves.This change:
vulkan-1.dllfrom the existinglibmpv-tempverified bundle to the Inno installerlibmpv-2.dllin the per-user Subtitle Edit data folderCurrent-base verification
build-ui.ymlstill copies all oflibmpv-temp/*into the Windows ZIP and explicitly documents the Vulkan dependencySubtitle_Edit_Installer.issstill stages onlylibmpv-2.dllfa6d8623c2adb0c646b6d31a11b221b855339bbeto7dbf7e03c937241ff9511ae413d5552720249de1; those intervening commits do not touch the installer or build workflow paths relevant to this changeBase is upstream
fa6d8623c2adb0c646b6d31a11b221b855339bbe.This PR supersedes internal draft #19.
AI assistance: ChatGPT was used to independently re-audit the current libmpv packaging paths, confirm the ZIP/Inno dependency mismatch, verify exact base-file identity, and port the minimal packaging fix.