Skip to content

Use verified Inno Setup 7.1.0 x64 in release build - #21

Draft
Blackspirits wants to merge 1 commit into
upl/review-base-18eefrom
ci/inno-7.1.0-x64-18ee
Draft

Use verified Inno Setup 7.1.0 x64 in release build#21
Blackspirits wants to merge 1 commit into
upl/review-base-18eefrom
ci/inno-7.1.0-x64-18ee

Conversation

@Blackspirits

Copy link
Copy Markdown
Owner

Summary

Update the Windows installer build from Inno Setup 6.7.3 to the current stable 7.1.0 x64 release and verify the downloaded installer before execution.

This change:

  • pins innosetup-7.1.0-x64.exe
  • verifies SHA-256 0362a383ed217d4c4239b5933866dd96d3eb2102737da92f80f6057a4b40df2f
  • uses the x64 Inno Setup 7 ISCC.exe

Validation

  • exact installer SHA-256 verified
  • Windows x64 publish passed
  • Inno Setup installation passed
  • real Subtitle Edit installer compilation passed
  • validation run: #34524488270

AI assistance: ChatGPT was used to audit the release workflow, verify the current Inno release, and prepare this minimal CI/toolchain update.

@Blackspirits
Blackspirits requested a lite review from Copilot September 11, 2026 00:28

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown

@Blackspirits Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is:

no supported setup-steps job found in your workflow file. Please ensure you have a job named copilot-code-review or copilot-setup-steps. For more details, see https://gh.io/copilot/actions-setup-steps

Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues remain.

Pull request overview

Updates the Windows release workflow to use a verified Inno Setup 7.1.0 x64 installer.

Changes:

  • Pins the installer and SHA-256 hash.
  • Verifies the download before execution.
  • Uses the Inno Setup 7 x64 compiler.
File summaries
File Description
.github/workflows/build-ui.yml Updates installer acquisition, verification, and compilation.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants