Skip to content

Use verified Inno Setup 7.1.0 x64 in release build #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Blackspirits wants to merge 1 commit into
base: upl/review-base-18ee
Choose a base branch
from
Draft

Use verified Inno Setup 7.1.0 x64 in release build #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/build-ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,17 +459,22 @@ jobs:
Copy-Item "libmpv-temp/libmpv-2.dll" "./src/ui/bin/Release/net10.0/publish/"
Get-ChildItem -Path "./src/ui/bin/Release/net10.0/publish" -Filter "*.pdb" -Recurse -File | Remove-Item -Force

- name: Install Inno Setup 6.7.3
# Pin an exact version: the .iss script requires 6.7.3+, but Chocolatey still ships 6.7.1.
- name: Install Inno Setup 7.1.0 x64
# Pin the exact x64 release and verify its hash before executing it.
run: |
$url = "https://github.com/jrsoftware/issrc/releases/download/is-6_7_3/innosetup-6.7.3.exe"
$url = "https://github.com/jrsoftware/issrc/releases/download/is-7_1_0/innosetup-7.1.0-x64.exe"
$expectedSha256 = "0362a383ed217d4c4239b5933866dd96d3eb2102737da92f80f6057a4b40df2f"
Invoke-WebRequest -Uri $url -OutFile "$env:RUNNER_TEMP\innosetup.exe"
$actualSha256 = (Get-FileHash "$env:RUNNER_TEMP\innosetup.exe" -Algorithm SHA256).Hash.ToLowerInvariant()
if ($actualSha256 -ne $expectedSha256) {
throw "Inno Setup SHA-256 mismatch: expected $expectedSha256, got $actualSha256"
}
Start-Process -FilePath "$env:RUNNER_TEMP\innosetup.exe" `
-ArgumentList "/VERYSILENT","/SUPPRESSMSGBOXES","/NORESTART","/SP-" -Wait

- name: Build Inno Setup installer
run: |
& "C:\Program Files (x86)\Inno Setup 6\ISCC.exe" "installer\WindowsInno\Subtitle_Edit_Installer.iss"
& "C:\Program Files\Inno Setup 7\ISCC.exe" "installer\WindowsInno\Subtitle_Edit_Installer.iss"
$setup = Get-ChildItem "installer\WindowsInno\SubtitleEdit-*-Setup.exe" | Select-Object -First 1
Copy-Item $setup.FullName "./SubtitleEdit-Windows-x64-Setup.exe"
Write-Host "Built Inno Setup installer: $($setup.Name)"
Expand Down
Loading