Verify libVLC downloads before unpack - #57
Conversation
|
Independent adversarial re-check on current upstream base: reconfirmed the Windows x64/x86 VideoLAN archive checksums and the macOS x64 |
|
Independent adversarial re-check on current upstream base: reconfirmed the two VideoLAN Windows checksums and the macOS |
|
Independent adversarial re-check on current upstream base: reconfirmed the Windows x64/x86 VideoLAN checksums and the macOS x64 |
Blackspirits
left a comment
There was a problem hiding this comment.
Independent adversarial re-check on current upstream base: reconfirmed the Windows x64/x86 VideoLAN archive digests and the macOS x64 support-files digest; file-backed downloads now fail closed before HTTP when the digest is missing, delete failed/tampered downloads, preserve valid downloads, and stream-backed downloads reject tampered/non-seekable content before unpack. Full current-base CI run #34706868169 passed on the first test run with no retry. No blocker identified. Keep draft; no merge/promotion performed.
Summary
The libVLC downloader fetches pinned Windows/macOS archives that are unpacked immediately by the settings installer, but the downloaded bytes are not authenticated before extraction.
This change:
Validation
vlc-3.0.23-win64.7z:eb4fd8a28291da73608c733786a09610fea865fbe94113bcb60b91c1ebb8404avlc-3.0.23-win32.7z:f148ff49cdac6c0b6b7018ad7c4e6cd24c99bc6c2dea8258d82684261a639017SubtitleEdit/support-filesreleasevlc3:301c3c4a78ae2339d075f557af7ab0006c427dbd3e903c4778c59de9684c353aBase is upstream
9be10e12d0f04655f2f134718b00679f89b2b15f.This PR supersedes internal draft #34.
AI assistance: ChatGPT was used to independently re-audit the libVLC download/unpack path on current upstream, reconfirm the official/published archive digests, strengthen fail-closed behavior, port the integrity fix, and add regression coverage.