Skip to content

feat: review does less, aimed better (MUSTs the range wrote, agents.skip, wider fold) - #56

Merged
sebastian-iancu merged 3 commits into
mainfrom
feat/review-cost
Oct 19, 2026
Merged

sebastian-iancu merged 3 commits into
mainfrom
feat/review-cost

Conversation

@sebastian-iancu

Copy link
Copy Markdown
Contributor

Summary

A review pass does less, aimed where defects were found. The conformance reviewer guards only the MUSTs the range wrote or reworded (plus at most three older ones), paths in agents.skip reach no reviewer, add folds another reviewer's suggestion into a blocking line on the same anchor, and the brief carries the two severity floors external reviewers never read.

Docs

references/review.md § Severity, § Scope, § The tool; traceability-schema.md (agents.skip); methodology §13; agents/sdd-spec-conformance-reviewer.md step 4; agents/sdd-doc-reviewer.md (no missing-keyword suggestion); sdd-scaffold (Go reviewer block map); sdd-review --panel (scope's flags); docs/examples.md.

Verification

  • ./scripts/validate.sh: OK, every word budget held (no raise).
  • unittest: 580 OK; sdd-check selftest: 26 OK; claude plugin validate .: passed.
  • Red before green: every new assertion failed first. Each new guard was then mutated (keyword set, rename pairing, header parsing, the same-reviewer rule, the batch count, the no-code conformance plan, the skip match), and a test failed each time.

Notes for review

  • binding_lines diffs the specifications folder whole with -M, so a renamed spec lists no MUSTs.
  • A folded suggestion stays as - [~] … deferred: merged into the blocking line on its anchor. It is never posted or harvested, and its words are kept.
  • One release (0.15.0) with the stacked PR on top.

Checklist

  • Scoped to one logical change
  • The gates above pass locally and their output was read
  • CHANGELOG entry under Unreleased
  • Both manifests untouched; AGENTS.md and README.md synced
  • No internal or private repository names, absolute paths or organisation-private details

🤖 Generated with Claude Code

sebastian-iancu and others added 3 commits October 19, 2026 13:58
…, agents.skip, wider fold

start writes into the brief the MUST, SHALL and REQUIRED lines the range
added or reworded, the guard command's form and the two severity floors
external reviewers otherwise never read. Paths agents.skip names go to no
reviewer, listed ten at a time. add folds a suggestion into a blocking line
on its anchor, whatever its words. A refusal that names another worktree
prints the command to run there, --root before the command.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w rules follow the tool

The conformance reviewer proves a guard for each binding sentence the brief
lists, and for at most three older ones whose guard or test changed.
review.md gives behaviour a caller can trigger an important floor, makes a
keyword missing from a sentence the code meets no lead, and names
agents.skip. sdd-scaffold suggests a Go reviewer map of *.go and go.mod, so
data and fixtures reach no Go reviewer. sdd-review --panel names the flags
scope takes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… fold keeps the suggestion

binding_lines diffs the specifications folder whole (the constitution on
the informative profile), so a renamed spec is no list of new MUSTs and a
changelog or README line is none; a content line that reads like a file
header is read as content. A MUST written with no code still plans the
conformance reviewer. add folds only another reviewer's suggestion into a
blocking line on its anchor and keeps it as a resolved line, its words
intact; a batch counts each input line once. The doc reviewer no longer
raises a missing keyword, and the examples and methodology §13 state the
guard rule the conformance reviewer now follows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sebastian-iancu
sebastian-iancu merged commit d292e0d into main Oct 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant