Skip to content

feat: one pass over the fixes only for code or a written MUST; a length rule for prose - #57

Merged
sebastian-iancu merged 3 commits into
feat/review-costfrom
feat/lean-after-triage
Oct 19, 2026
Merged

sebastian-iancu merged 3 commits into
feat/review-costfrom
feat/lean-after-triage

Conversation

@sebastian-iancu

Copy link
Copy Markdown
Contributor

Summary

Less work after triage, and shorter text. After the maintainer's review, the pass over the fixes runs only when a fix changed code or wrote a MUST, and triage proves each MUST it writes with one sdd-pr guard run. A length rule caps a finding at about 30 words and a PR body at about 300 besides the checklist.

Docs

references/review.md § Passes (defines a written MUST); references/artefact-prose.md § Prose register; sdd-triage, sdd-close; the PR-body and AGENTS.md templates; docs/quick-start.md; this repository's PR template.

Verification

  • ./scripts/validate.sh: OK, every word budget held (no raise).
  • unittest: 580 OK; claude plugin validate .: passed.
  • Red before green: the status steer assertion failed first, and setting review_due = code_changed made it fail again.

Notes for review

  • Stacked on the review-cost PR; merge that one first.
  • Left alone on purpose: the worker brief (brief.md) and the one-line reviewer dispatch.

Checklist

  • Scoped to one logical change
  • The gates above pass locally and their output was read
  • CHANGELOG entry under Unreleased
  • Both manifests untouched; AGENTS.md and README.md synced
  • No internal or private repository names, absolute paths or organisation-private details

🤖 Generated with Claude Code

sebastian-iancu and others added 3 commits October 19, 2026 14:17
…ing sentence; triage proves its MUSTs

After the maintainer's review, a fix that only rewords other text gets no
re-review: review.md § Passes, the triage step and sdd-pr status's Next
line now agree. A binding sentence a triage fix writes is proven with one
sdd-pr guard run before its flip, the check the next pass used to make.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
artefact-prose.md § Prose register caps a finding at about 30 words and a
PR body at about 300 besides its checklist, and asks a report for one item
per line. sdd-close and the review brief apply it; the PR-body template
asks for a three-sentence Summary and at most three notes; the AGENTS.md
template carries the short form.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review.md § Passes says what a written MUST is (a MUST, SHALL or REQUIRED
line added to a specification, or the constitution on the informative
profile); triage, status, the quick start and the tables use that term.
This repository's PR template asks for the same short Summary and notes as
the scaffolded one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sebastian-iancu
sebastian-iancu merged commit a68d6cb into feat/review-cost Oct 19, 2026
2 checks passed
@sebastian-iancu
sebastian-iancu deleted the feat/lean-after-triage branch October 19, 2026 14:20
sebastian-iancu added a commit that referenced this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant