Repository navigation
Quoted value set element with surrounding whitespace is refused for temporal sets; PostgreSQL accepts it #70
Description
A temporal value set throws on a quoted element with leading or trailing whitespace, but PostgreSQL accepts it. This is the value-set version of #45.
DateSet.Parse("{\" 2026-01-01\"}", null); // FormatException
TimeSet.Parse("{\" 09:00\"}", null); // FormatException
Int32Set.Parse("{\" 1\"}", null); // {1}, because int.Parse trimsSELECT '{" 2026-01-01"}'::date[]; -- {2026-01-01}
SELECT '{" 09:00"}'::time[]; -- {09:00:00}
SELECT '{" ab"}'::text[]; -- {" ab"}: textin keeps itarray_in hands a quoted element to the element input function with its whitespace intact. date_in, time_in, timestamp_in, timestamptz_in, int4in and numeric_in strip ASCII whitespace from both ends (measured on PostgreSQL 17, see #45). textin keeps it. So trimming can't happen in SetFormat for every family: StringSet and the string wrapper arities have to keep the space. It belongs to the families whose PostgreSQL input function trims.
Before matching it, measure uuid_in and the NodaTime families' store types (date, timestamp, timestamptz, time, and YearMonthSet's date). It fails loudly and only accepts more, so it fits a minor release.
Found while fixing #45.
Activity
CaffeinatedCoder commentedon Oct 17, 2026
Measured on PostgreSQL 17.10 (
postgres:17-alpine)For each element type, I tried six ASCII whitespace characters (space, tab, LF, CR, VT, FF) plus U+00A0 and U+2003. The forms were:
{" x"}{\ x}{ x}{" "}array_initself drops whitespace around a bare element. It passes quoted and escaped whitespace to the element input function.int2,int4,int8,numericdate(alsoinfinity),timestamp,timestamptz,timeuuidarray_indrops it)text{" ab"}){" "})What the library does today
Int16Set,Int32Set,Int64SetandDecimalSet(the BCL number parsers trim exactly these six characters), andStringSet, which keeps everything.DateSet,DateTimeSet,DateTimeOffsetSet,TimeSet,LocalDateSet,LocalDateTimeSet,InstantSet,LocalTimeSetandYearMonthSet(stored asdate[]) throw on quoted or escaped ASCII whitespace. PostgreSQL strips it.GuidSetaccepts quoted and escaped whitespace, and a no-break space even bare.Guid.Parsetrims all Unicode whitespace, butuuid_inrejects it. Fixing that rejects input that parses today.Fix for this issue: each temporal family's element parser (
ParseValue, whichParse,TryParse, JSON, theTypeConverterand the wrapper arities all use) trims these six characters, and only them. Nothing changes forStringSetor the string wrapper arities.CaffeinatedCoder commentedon Oct 17, 2026
Oracle check (main at 3ecfa10): Would be caught today (retroactive; no oracle found it at the time) by
SetElementWhiteSpaceContractTestsandLiteralGrammarParityTests, seedtemporal-set-element-whitespace-kept. The failing rows:SetElementWhiteSpaceContractTests(EverySetType_ReadsElementWhitespaceAsItsInputFunctionDoes, 1,080 lines, e.g.DateSet: Parse rejected {" 2024-06-15 "}, expected {2024-06-15}, through Parse, TryParse, TypeConverter and JSON) andLiteralGrammarParityTests(ElementWhitespace_ReadsAsPostgresReadsIt, 324 lines,date[] DateSet {" 2026-01-01"}: library refused, PostgreSQL {2026-01-01}).Verified by a run: I reverse-applied #81's
src/diff on 3ecfa10 and ran every registered oracle. These two methods failed, and nothing else did.CaffeinatedCoder commentedon Oct 17, 2026
Would be caught today by
LiteralCorpusProbeTests(#135). This is retroactive:LiteralGrammarParityTestsfound it, and #81 fixed it. Row:DateSet whitespace {" 2026-01-01"}, library refused (FormatException), PostgreSQL reads{2026-01-01}. The same happens on every temporal set family and its wrapper arity (BCL and NodaTime), for a trailing space and for{\ …}. Verified by applyingtest/oracles/seeds/temporal-set-element-whitespace-kept.patch(the revert of #81's fix) to main + #135 and running the class against postgres:17: 16 of 49 rows fail with 48 lines. That seed now namesLiteralCorpusProbeTeststoo.test: infinity-bound and quoted-whitespace rows in the literal corpus…