Repository navigation
feat(fee): emit versioned events for init, set_fee, deposit, and withdraw (#1189) - #1377
Closed
lienhoatienphung-svg wants to merge 1 commit into
Closed
lienhoatienphung-svg wants to merge 1 commit into
lienhoatienphung-svg wants to merge 1 commit into
Conversation
lienhoatienphung-svg
force-pushed
the
feature/1189-fee-lifecycle-events
branch
from
October 16, 2026 07:18
8a0c0fb to
fff1b50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emits structured, versioned events following the
(name, v1, subject)topic convention across all state-changing entrypoints inFeeContract(init,set_fee,deposit, andwithdraw).Key Changes
contracts/fee/src/lib.rs:init: emits("fee_init", "v1", admin)with initial0u32fee bps.set_fee: emits("fee_set", "v1", admin)with(old_fee_bps, fee_bps).deposit: emits("fee_deposited", "v1", caller)with(amount, new_accumulated).withdraw: emits("fee_withdrawn", "v1", admin)with(recipient, amount).test_events_emitted_for_init_set_fee_deposit_and_withdrawandtest_events_not_emitted_on_zero_or_negative_deposit.Closes #1189
Payout Wallet (Base USDC / EVM):
0x3806cd592a508d1992Ed007C2F53de251C2E7452