Skip to content

fix(hot): re-export HotError and fix try_init return handling in fuzz target (#1185) #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lienhoatienphung-svg wants to merge 1 commit into from
Closed

fix(hot): re-export HotError and fix try_init return handling in fuzz target (#1185) #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions contracts/hot/fuzz/targets/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ fn run_sequence(ops: &[HotOp]) {
let mut current_admin = admin.clone();
let mut current_signer = signer.clone();
let mut cooldown = FUZZ_COOLDOWN;
let mut unpaused_in_window = false;

for op in ops {
match *op {
Expand All @@ -159,9 +160,9 @@ fn run_sequence(ops: &[HotOp]) {
HotOp::DoubleInit => {
if initialized {
let result = catch_unwind(AssertUnwindSafe(|| {
client.try_init(&admin, &signer, &Some(FUZZ_COOLDOWN));
client.try_init(&admin, &signer, &Some(FUZZ_COOLDOWN))
}));
if let Ok(Err(e)) = result {
if let Ok(Err(Ok(e))) = result {
assert_eq!(e, HotError::AlreadyInitialized);
}
}
Expand Down Expand Up @@ -205,6 +206,11 @@ fn run_sequence(ops: &[HotOp]) {
let result = catch_unwind(AssertUnwindSafe(|| client.unpause(&current_admin)));
match result {
Ok(()) => {
assert!(
!unpaused_in_window,
"two unpause calls must never both succeed inside one cooldown window"
);
unpaused_in_window = true;
paused = false;
assert!(!client.is_paused());
}
Expand Down Expand Up @@ -341,6 +347,7 @@ fn run_sequence(ops: &[HotOp]) {
// Advance ledger timestamp so cooldowns may expire.
let now = env.ledger().timestamp();
env.ledger().set_timestamp(now + cooldown + 1);
unpaused_in_window = false;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion contracts/hot/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pub mod errors;
pub mod events;
pub mod pause;

use errors::HotError;
pub use errors::HotError;
use soroban_sdk::{contract, contractimpl, contracttype, Address, Env, Symbol};

// ---------------------------------------------------------------------------
Expand Down