Repository navigation
update ureq to 3 - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Bumps ureq to 3. The MNIST download is the only caller, and the one change is that the reader now comes from the response body (
into_body().into_reader()).Why
Replaces #33, which failed because ureq 3 moved
into_readeroff the response.The body reader in 3.x has no size limit, same as 2.x, so the 9.9 MB training images still download without hitting the 10 MB cap
read_to_vecwould have.How it was verified
cargo testpassescargo clippy --all-targets -- -D warningsis cleancargo checkon 1.87 with a fresh lockfile