Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review finding R20.
Valid RPC parameters such as
client,writer, anddata, escaped keywords such as@event, and repeated nullable struct field names could make generated C# fail to compile. Preserve raw symbol and wire names, escape C# member references, and allocate generated parameters and temporaries against all user parameter names. Nested serializer presence flags now include their field path.Add six regressions that run both the analyzer and generator before executing generated code. Coverage includes local and remote RPC/broadcast delivery in event and explicit receive modes, generated-prefix parameter names, escaped properties/collections and their wire names, stable message IDs, and nested nullable struct/object roundtrips.
Validation:
dotnet test Cat.Network.sln -c Release --verbosity minimalpasses all 234 tests (155 runtime, 53 analyzer, 26 generator).Composition: when combining with R4 (#11), retain its session/profile guard after local broadcast delivery. R21 and R22 also modify message emission; preserve both their changes and R20's identifier allocation.