Repository navigation
Add accessible name to the font scaling slider - #4993
Conversation
FontScalingSlider had no AutomationProperties.Name, so screen readers announce it as an unnamed slider with only a raw numeric value. Completes the accessible-name coverage of the font scaling popup.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe font-scaling slider now includes the automation name ChangesFont Scaling Accessibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change gives the font scaling slider an accessible name for screen-reader users without altering its behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Win11 Creator wizard (#4925) was merged after the top-bar naming pass in #4992/#4993. Its glyph-only Back/Forward buttons report the Segoe MDL2 private-use character as their UI Automation name, and the ISO path box, the edition and USB combo boxes and the status log have an empty name because their visible labels are separate TextBlocks. Add AutomationProperties.Name to all six: "Previous Step" and "Next Step" for the arrows, and the visible label text for the other four. Cover them with a XAML test. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Chris Titus <contact@christitus.com>
Type of Change
Description
FontScalingSliderin the font scaling popup has noAutomationProperties.Name, so screen readers (Narrator, NVDA) announce it as an unnamed slider with only a raw numeric value — the surrounding "Small"/"Large"/percentage TextBlocks are not associated with the control. This addsAutomationProperties.Name="Font Scaling"so the slider is announced by name.One-attribute XAML change, companion to #4992 (which names the popup's toggle button and the other top-bar controls). Verified with
.\Compile.ps1 -Run+ Narrator; full Pester suite passes (549/549).Issue related to PR