Repository navigation
docs(agents): state each classification and priority rule in one place - #1234
Conversation
Review feedback (Bugbot on ClickHouse/clickhouse-cs#746): the severity rows are read top-down and the first match wins, and "Workaround exists" still matched the impact Performance of a speed request before the exception further down. The row now covers the impact Performance of a defect only and points a speed request to the feature row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved by the AI review gate on ddac245. Details in the approver's comment on this pull request.
AI review gate — auto-approved
History (latest 5 heads, newest first)
|
Bugbot found a new gap after each small fix, because some rules were in two to four places with different words. Each rule is now in one place: - classification: new boundaries "Hostile server or network" and "Dependencies"; the Security row and the private-report list point to them; - priority: the severity rows carry the speed-request and dependency rules (row 1 for a dependency vulnerability only when the client calls the vulnerable code; the feature row names speed requests and dependency updates); the vulnerability section only points to the classification. Checked against a fixed case table (speed requests, authentication, leaked secrets, hostile servers, memory corruption, called / not called / unpublished dependency vulnerabilities, code-only evidence). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## Summary Follow-up to #1157 (merged). Cursor Bugbot found a new gap after each small fix, because some rules were in two to four places with different words. This PR states each rule in **one place**, and checks the result against a fixed case table. - **Classification** (`.claude/skills/issue-classification/SKILL.md`): two new boundaries, **"Hostile server or network"** and **"Dependencies"**. The Security row and the list of "A vulnerability that is not public yet" point to them. - **Priority** (`.claude/skills/issue-priority/SKILL.md`): the severity rows carry the rules. The first row covers a vulnerability in a dependency only when the client calls the vulnerable code. "Workaround exists" covers the impact Performance of a defect only. The last row names speed requests and dependency updates, also one for a dependency vulnerability in code that the client does not call. The section "Vulnerabilities that are not public yet" only points to the classification; the separate speed and dependency paragraphs are gone. ## Case table (expected outcome → the text gives it) | Case | Classification | Public or private | Severity row | |---|---|---|---| | Request to make an operation faster | Performance | public | Cosmetic, docs, feature | | Correct result, but too slow | Performance | public | Workaround exists | | Missing authentication method | Security (authentication) | public | Cosmetic, docs, feature | | Authentication method that does not work | Security (authentication) | public | by its failure | | Secret that leaks (log, error, URL, other host) | Security (vulnerability) | private | Wrong data or security (proposed severity) | | Hang, or crash with no memory corruption, only from a hostile server or network | Stability | public | by its failure | | Memory corruption, also only from a hostile server or network | Security (vulnerability) | private | Wrong data or security (proposed severity) | | Crash on server data, memory corruption not ruled out | not decided | private until decided | — | | Published CVE or GHSA, client calls the code | Security (vulnerability) | public | Wrong data or security | | Published CVE or GHSA, client does not call the code | none (dependency update) | public | Cosmetic, docs, feature | | Unpublished dependency vulnerability, client calls the code | Security (vulnerability) | private | Wrong data or security (proposed severity) | | Unpublished dependency vulnerability, client does not call the code | Security (vulnerability) | private | Cosmetic, docs, feature (proposed severity) | | Vulnerability that only code inspection shows | as above | private | confidence `MEDIUM` | The other client repositories get the same text (ClickHouse/clickhouse-cs#746, #1158, ClickHouse/clickhouse-go#2146, ClickHouse/ch-go#1234, ClickHouse/clickhouse-cpp#619, ClickHouse/clickhouse-odbc#619). No library code changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only updates to agent triage skills; no runtime or product code changes. > > **Overview** > Follow-up to prior skill tweaks: **issue-priority** no longer lets “please make this faster” land on **Workaround exists** (`Medium` at Core) because the first matching severity row wins. That row now covers **Performance** only for defects (correct but slow); speed **requests** are explicitly routed to **Cosmetic, docs, feature**, along with dependency bumps where the client does not call vulnerable code. The **Wrong data or security** row likewise limits dependency CVEs to cases where the client actually invokes the vulnerable code. > > **issue-classification** is reorganized, not behaviorally flipped: hostile-server hangs/crashes, dependency vulnerability scope, and private-disclosure notes move into dedicated **Boundaries** bullets, and the Security / unpublished-vulnerability sections cross-reference those instead of repeating long prose (plus minor table formatting). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 80cc234. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Polyglot AI <293096396+polyglotAI-bot@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
AI review gate — AI review passedClean review from: Cursor Bugbot. |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit cf43609. Configure here.
There was a problem hiding this comment.
Auto-approved by the AI review gate on cf43609. Details in the approver's comment on this pull request.
Summary
Follow-up to #1233 (merged). Cursor Bugbot found a new gap after each small fix, because some rules were in two to four places with different words. This PR states each rule in one place, and checks the result against a fixed case table.
.claude/skills/issue-classification/SKILL.md): two new boundaries, "Hostile server or network" and "Dependencies". The Security row and the list of "A vulnerability that is not public yet" point to them..claude/skills/issue-priority/SKILL.md): the severity rows carry the rules. The first row covers a vulnerability in a dependency only when the client calls the vulnerable code. "Workaround exists" covers the impact Performance of a defect only. The last row names speed requests and dependency updates, also one for a dependency vulnerability in code that the client does not call. The section "Vulnerabilities that are not public yet" only points to the classification; the separate speed and dependency paragraphs are gone.Case table (expected outcome → the text gives it)
MEDIUMThe other client repositories get the same text (ClickHouse/clickhouse-cs#746, ClickHouse/clickhouse-js#1158, ClickHouse/clickhouse-go#2146, #1234, ClickHouse/clickhouse-cpp#619, ClickHouse/clickhouse-odbc#619). No library code changes.
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only changes to
.claude/skillswith no runtime or application code affected.Overview
Refactors issue-classification and issue-priority agent skill docs so each rule lives in a single place, with cross-references instead of duplicated wording.
Classification adds boundary sections Hostile server or network and Dependencies; the Security impact row and the confirmed-vulnerability checklist now defer to those sections instead of inlining long explanations.
Priority moves speed requests, dependency updates, and dependency-vulnerability severity into the severity table rows; trims the unpublished-vulnerability section to a pointer to classification; and removes the standalone paragraphs that repeated the same logic.
Reviewed by Cursor Bugbot for commit cf43609. Bugbot is set up for automated code reviews on this repo. Configure here.