Skip to content

docs: state each classification and priority rule in one place - #1158

Merged
ccoltx merged 2 commits into
mainfrom
polyglot/issue-priority-speed-requests
Nov 18, 2026
Merged

ccoltx merged 2 commits into
mainfrom
polyglot/issue-priority-speed-requests

Conversation

@polyglotAI-bot

@polyglotAI-bot polyglotAI-bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #1157 (merged). Cursor Bugbot found a new gap after each small fix, because some rules were in two to four places with different words. This PR states each rule in one place, and checks the result against a fixed case table.

  • Classification (.claude/skills/issue-classification/SKILL.md): two new boundaries, "Hostile server or network" and "Dependencies". The Security row and the list of "A vulnerability that is not public yet" point to them.
  • Priority (.claude/skills/issue-priority/SKILL.md): the severity rows carry the rules. The first row covers a vulnerability in a dependency only when the client calls the vulnerable code. "Workaround exists" covers the impact Performance of a defect only. The last row names speed requests and dependency updates, also one for a dependency vulnerability in code that the client does not call. The section "Vulnerabilities that are not public yet" only points to the classification; the separate speed and dependency paragraphs are gone.

Case table (expected outcome → the text gives it)

Case Classification Public or private Severity row
Request to make an operation faster Performance public Cosmetic, docs, feature
Correct result, but too slow Performance public Workaround exists
Missing authentication method Security (authentication) public Cosmetic, docs, feature
Authentication method that does not work Security (authentication) public by its failure
Secret that leaks (log, error, URL, other host) Security (vulnerability) private Wrong data or security (proposed severity)
Hang, or crash with no memory corruption, only from a hostile server or network Stability public by its failure
Memory corruption, also only from a hostile server or network Security (vulnerability) private Wrong data or security (proposed severity)
Crash on server data, memory corruption not ruled out not decided private until decided —
Published CVE or GHSA, client calls the code Security (vulnerability) public Wrong data or security
Published CVE or GHSA, client does not call the code none (dependency update) public Cosmetic, docs, feature
Unpublished dependency vulnerability, client calls the code Security (vulnerability) private Wrong data or security (proposed severity)
Unpublished dependency vulnerability, client does not call the code Security (vulnerability) private Cosmetic, docs, feature (proposed severity)
Vulnerability that only code inspection shows as above private confidence MEDIUM

The other client repositories get the same text (ClickHouse/clickhouse-cs#746, #1158, ClickHouse/clickhouse-go#2146, ClickHouse/ch-go#1234, ClickHouse/clickhouse-cpp#619, ClickHouse/clickhouse-odbc#619). No library code changes.

🤖 Generated with Claude Code


Note

Low Risk
Documentation-only updates to agent triage skills; no runtime or product code changes.

Overview
Follow-up to prior skill tweaks: issue-priority no longer lets “please make this faster” land on Workaround exists (Medium at Core) because the first matching severity row wins. That row now covers Performance only for defects (correct but slow); speed requests are explicitly routed to Cosmetic, docs, feature, along with dependency bumps where the client does not call vulnerable code. The Wrong data or security row likewise limits dependency CVEs to cases where the client actually invokes the vulnerable code.

issue-classification is reorganized, not behaviorally flipped: hostile-server hangs/crashes, dependency vulnerability scope, and private-disclosure notes move into dedicated Boundaries bullets, and the Security / unpublished-vulnerability sections cross-reference those instead of repeating long prose (plus minor table formatting).

Reviewed by Cursor Bugbot for commit 80cc234. Bugbot is set up for automated code reviews on this repo. Configure here.

Review feedback (Bugbot on ClickHouse/clickhouse-cs#746): the severity
rows are read top-down and the first match wins, and "Workaround exists"
still matched the impact Performance of a speed request before the
exception further down. The row now covers the impact Performance of a
defect only and points a speed request to the feature row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@polyglotAI-bot
polyglotAI-bot requested review from a team, kavirajk and mshustov as code owners November 18, 2026 19:52
Copilot AI balanced review requested due to automatic review settings November 18, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for this documentation-only clarification distinguishing performance defects from speed-improvement requests.

No open issues 🎉

What changed in this PR

This documentation-only follow-up to #1157 clarifies issue triage so speed improvement requests do not match the higher-priority performance-defect row. It does not change runtime behavior, public APIs, or priority levels.

Changes:

  • Limits the “Workaround exists” row’s Performance clause to defects.
  • Explicitly directs requests to make an operation faster to “Cosmetic, docs, feature.”
File Description
.claude/​skills/​issue-priority/​SKILL.md Distinguishes performance defects from speed improvement requests in the severity table.

Review effort: Balanced

@security-ai-gate-reviewer security-ai-gate-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by the AI review gate on b1b0156. Details in the approver's comment on this pull request.

@security-ai-gate-reviewer

security-ai-gate-reviewer Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

AI review gate — auto-approved

80cc2347f16f is approved by security-ai-gate-reviewer[bot], an automated identity, not a human. The approval stands on the required AI review: Cursor Bugbot concluded green on this commit and the AI review gate is SUCCESS (its own comment has the verdict), and the change touches no path that requires a human reviewer. It is bound to this commit: a new push dismisses it and the approver re-evaluates.

History (latest 5 heads, newest first)

  • 80cc2347f16f approved — green: Cursor Bugbot
  • b1b0156ae69e approved — green: Cursor Bugbot

Bugbot found a new gap after each small fix, because some rules were in
two to four places with different words. Each rule is now in one place:
- classification: new boundaries "Hostile server or network" and
  "Dependencies"; the Security row and the private-report list point to
  them;
- priority: the severity rows carry the speed-request and dependency
  rules (row 1 for a dependency vulnerability only when the client calls
  the vulnerable code; the feature row names speed requests and
  dependency updates); the vulnerability section only points to the
  classification.
Checked against a fixed case table (speed requests, authentication,
leaked secrets, hostile servers, memory corruption, called / not called
/ unpublished dependency vulnerabilities, code-only evidence).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@security-ai-gate-reviewer security-ai-gate-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by the AI review gate on 80cc234. Details in the approver's comment on this pull request.

@ccoltx
ccoltx merged commit 39192ec into main Nov 18, 2026
12 checks passed
@ccoltx
ccoltx deleted the polyglot/issue-priority-speed-requests branch November 18, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants