Repository navigation
docs(agents): add the issue-priority skill for the Priority issue field - #743
polyglotAI-bot wants to merge 2 commits into
Conversation
The skill gives the rules for the org issue field Priority (Urgent, High, Medium, Low) on clickhouse-cs issues: reach tiers of the HTTP and TCP clients, severity, the base-level matrix, modifiers, and confidence. People and automated triage use the same rules. AGENTS.md points to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Conflicting scope classifications and overlapping workaround rules can produce inconsistent priorities for session-only failures and missing conversions.
2 open issues
What changed in this PR
Adds a shared policy for people and automated tools to set the organization’s Priority issue field. The policy covers both HTTP and TCP client issues; no package code or runtime behavior changes.
Changes:
- Defines reach tiers, severity levels, a priority matrix, modifiers, and exclusions.
- Specifies confidence, reason formatting, and handling of defects shared by both clients.
- Links the policy from the repository’s issue-triage guidance.
| File | Description |
|---|---|
AGENTS.md |
Adds an Issue triage section linking to the priority skill. |
.claude/skills/issue-priority/SKILL.md |
Defines the rules for assigning and explaining issue priority. |
Review effort: Balanced
| shows only with a rare type, a non-default setting, or an unusual server setup | ||
| is Narrow, also when it goes through `ClickHouseClient` or the ADO.NET API. |
| | ----------------------- | -------- | | ||
| | Wrong data or security | the client returns or stores wrong or incomplete data with no error, or reports success for a query or insert that failed; or a security defect | | ||
| | Broken, no workaround | the feature fails (an exception, a hang, a crash, a stack overflow, a leak that ends in a crash or in exhausted connections), and the caller has no reasonable workaround; also a wrong or incomplete error with no workaround: the failure is reported, but its type, code, or message is wrong or lost | | ||
| | Workaround exists | the feature fails, but the caller can avoid the failure with a small change in their own code, for example a cast in SQL, another overload, or another setting (name the workaround in the reason); also a result that is correct but slow or uses too much memory | |
There was a problem hiding this comment.
Auto-approved by the AI review gate on 35f7b7d. Details in the approver's comment on this pull request.
AI review gate — auto-approved
History (latest 5 heads, newest first)
|
The severity section now starts with four impact classes: Security, Data integrity, Stability, and Performance. They are the same in every ClickHouse client repository. Each severity row names the impact that puts an issue in the row, and the reason line records the impacts. No priority level changes: each row keeps its conditions. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
I pushed one more commit after the approval: the severity section now names four impact classes (Security, Data integrity, Stability, Performance). The classes are the same in every ClickHouse client repository.
The description has a new section "Impact classes" with the same summary. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 86419a4. Configure here.
|
|
||
| | Severity | Use when | | ||
| | ----------------------- | -------- | | ||
| | Wrong data or security | impact **Data integrity**: the client returns or stores wrong or incomplete data with no error, or reports success for a query or insert that failed; or impact **Security**: a security defect (a request for an authentication method is a feature request) | |
There was a problem hiding this comment.
Auth impact conflicts with feature requests
Medium Severity
The Security impact treats a missing authentication method as a security defect, while the Wrong data or security row treats a request for an authentication method as a feature request. Auth is a Core path, so the required impact-first reading yields Urgent instead of Low, and triage never revises a Priority that is already set.
Reviewed by Cursor Bugbot for commit 86419a4. Configure here.
AI review gate — Cursor Bugbot found issues
Unresolved findings (1): What to do:
Re-run the gate with “Re-run jobs” after an approval or a finished review. A push re-runs it automatically. |



Summary
Adds
.claude/skills/issue-priority/SKILL.md: the rules for the org issue field Priority (Urgent,High,Medium,Low) on clickhouse-cs issues. People and automated triage use the same file.AGENTS.mdpoints to it in a new "Issue triage" section. clickhouse-js has the same skill (ClickHouse/clickhouse-js#1136), with reach tiers of its own.The rules:
ClickHouseClientor ADO.NET.ClickHouseClient, the ADO.NET API that Dapper, EF Core and linq2db use), connection-string parsing, transport, auth/TLS, errors, parameters, and the common types.JSONtype with typed paths, sessions and roles,QueryOptions/InsertOptions, ZSTD, OpenTelemetry and logging, the DI extensions.CHTCP0001), rare types, fixed-offset time zones, rarely used settings,GetSchema/GetSchemaTable, a specific server setup (readonlyuser, proxy, cluster).Urgent; a regression in the latestX.Y.Zrelease (not-rcN) → up one level; a customer request linked from Linear → up one level, never toUrgent.[Obsolete]API reaches (for exampleClickHouseBulkCopy), for servers below the support floor, and for questions, CI, dependency, or release-process issues.Impact classes (added 2026-11-17)
The severity section now starts with four impact classes: Security, Data integrity, Stability, and Performance. They are the same in every ClickHouse client repository, so that issues are classified with the same words in each client.
Calibration against the 5 values that are already set
alex-clickhouse set all 5. These rules give the same value for 3 of them: #438, #439 and #440 are
Low. The other 2 are one level higher:Fixed/UTC±HH:MM:SSzone dropped, wall clock shiftedDynamic/VariantJSON hint +ReadStringsAsByteArraysThe matrix is the same as in clickhouse-js: silent wrong data on a narrow path gives
High. If you prefer your earlier ratings, change two cells in section 3: Narrow × "Wrong data or security" →Medium, and Satellite →Low.Change the tiers or the matrix as you like. The triage job reads this file from
mainon every run, and it never changes a Priority that is already set.No package code changes, so no changelog fragment.
🤖 Generated with Claude Code
Note
Low Risk
Documentation and agent guidance only; no runtime or package behavior changes.
Overview
Adds
.claude/skills/issue-priority/SKILL.mdas the canonical rules for the org-only Priority issue field onclickhouse-cs. The skill defines when to skip priority, reach tiers (Core → Satellite) tied to public APIs and conditions, impact/severity, the base reach×severity matrix, modifiers (untrusted-input security, release regressions, Linear customer links), confidence, one-line reason format, and how to rate defects that exist in both HTTP and TCP clients.AGENTS.mdgains an Issue triage section that points maintainers and automation at that skill for setting, checking, or explaining priority.Reviewed by Cursor Bugbot for commit 86419a4. Bugbot is set up for automated code reviews on this repo. Configure here.