Repository navigation
Conversation
…nd UDF permissions
Refresh the vendored ClickHouse Cloud OpenAPI snapshot and fix the
cross-cutting and services drift it reports:
- Service, ServiceScalingPatchResponse, ServicePostRequest and
ServicePatchRequest gain optional `deletion_protection`; ActivityType adds
`service_update_deletion_protection` (Activity.type is now an open string
in the spec; the enum keeps its catch-all).
- Regenerate meta/operations.rs: the UDF operations now require
control-plane:organization:{manage,view}-udfs.
- ClickPipePostRequest/ClickPipePatchRequest `settings` is now
ClickPipeSettingsPutRequest, as the spec types it. The fields are identical,
so the wire body is unchanged; ClickPipeSettings stays as a type alias.
Drop the two now-stale ClickPipeSettings optionality exemptions.
- CLI: `cloud service update` sends no deletionProtection (pinned by the
existing builder tests); live test literals gain the new field.
Refs #1466
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1466. API PR 1 of 3 (stacked: services → postgres → clickstack). CLI exposure follows in #1470.
meta/operations.rsfor the newmanage-udfs/view-udfspermissions.ClickPipePostRequest.settings/ClickPipePatchRequest.settingstoClickPipeSettingsPutRequest.ClickPipeSettingsstays as an alias, and the wire body is unchanged (pinned by a test). Drop two stale optionality exemptions.ActivityType::Service_update_deletion_protection; unknown values still go toUnknown(String).deletion_protection: Option<bool>onService,ServiceScalingPatchResponse,ServicePostRequestandServicePatchRequest, with wiremock coverage, including a 409 on delete. New non-blocking live step; live cleanup turns protection off before deleting.deletion_protection: None(pinned in builder tests).spec_coverage_testand three analyzer entrypoint tests are expected to fail on this PR. Their failures list only the Postgres and ClickStack drift that the next two PRs fix.🤖 Generated with Claude Code
Note
Medium Risk
UDF permission scope changes can break callers using only organization manage/view keys, and deletion protection affects service delete behavior (409) plus test cleanup paths.
Overview
Refreshes the vendored ClickHouse Cloud OpenAPI snapshot and regenerates the Rust client to match.
Service deletion protection is modeled as optional
deletion_protectionon create, patch, get, and scaling responses. While enabled, delete is documented (and tested) to return 409. Live integration and test cleanup disable protection before deleting so leaked services do not block teardown.UDF operations in
meta::operationsnow requirecontrol-plane:organization:manage-udfs/view-udfsinstead of the broader organization manage/view permissions.ClickPipe create and PATCH
settingsare typed asClickPipeSettingsPutRequest;ClickPipeSettingsremains a type alias so existing callers and wire JSON stay the same. The openapi analyzer drops redundant optionality exemptions now covered by that schema.Activity adds
Service_update_deletion_protection, andActivity.typeis treated as an open string (unknown values still map toActivityType::Unknown).The broader spec diff also documents Postgres GA (beta badges removed), ClickStack alert filters, BYOC vertical autoscaling, JWT bearerJwt auth scheme, and other schema/docs tweaks that land in the snapshot without separate Rust API changes in this PR.
clickhousectlcompiles withdeletion_protection: Noneuntil CLI support lands in a follow-up.Reviewed by Cursor Bugbot for commit 10475ff. Bugbot is set up for automated code reviews on this repo. Configure here.