Cape Town | 26-ITP-May | Shafiek Walker | Sprint 1 | Coursework Exercises by shafiekwalker7861 · Pull Request #1387 · CodeYourFuture/Module-Structuring-and-Testing-Data

shafiekwalker7861 · 2026-06-23T09:24:45Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed all Sprint 1 mandatory exercises, including implementing functions, interpreting code, and debugging. Tested all solutions before submitting.

Luro91

Good job. Most exercisers are done. I have couple of comments on some of them

Luro91 · 2026-06-24T04:33:42Z

+// The error is what I predicted. The slice method is not a function that can be used on numbers, only strings.
+
 // Then try updating the expression last4Digits is assigned to, in order to get the correct value
+const last4Digits = cardNumber % 10000;


This produces an error: "Uncaught SyntaxError: redeclaration of const last4Digits". HOw can you fix this?

Luro91 · 2026-06-24T04:37:15Z

+// The error was on line 5. The replaceAll() function call was missing the correct closing bracket/parenthesis.
+// I fixed it by making the line: priceAfterOneYear = Number(priceAfterOneYear.replaceAll(",", ""));


The code is working now, but the change was not adding a brackent/parenthesis. What did change?

Luro91 · 2026-06-24T04:38:32Z

+

 // d) Identify all the lines that are variable declarations
+// line 1 and 2 are variable declarations because they are declared using the let keyword.


Are thre other variable declarations?

Luro91 · 2026-06-24T04:41:49Z


 // e) What do you think the variable result represents? Can you think of a better name for this variable?
+// The variable result represents the total length of the movie in hours, minutes, and seconds.
+// A better name for this variable could be "movieDuration".


movieDuration is already better and clearer to understand. A common name for strings is to use the prefix formatted so formattedMovieLenght would also work

Luro91 · 2026-06-24T04:44:09Z

+// A better name for this variable could be "movieDuration".

 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
+// The code works for non-negative whole numbers. Negative or decimal values may produce incorrect or unexpected results.


What happens if the movieLength is 3665?

Luro91 · 2026-06-24T04:48:56Z

 // It will help to think about the order in which expressions are evaluated
 // Try logging the value of num and running the program several times to build an idea of what the program is doing
+
+// Math.random() generates a random decimal, 


What are the characteristics of the created float number?

Luro91 · 2026-06-24T04:49:23Z

 // Try logging the value of num and running the program several times to build an idea of what the program is doing
+
+// Math.random() generates a random decimal, 
+// Math.floor() rounds it down, and the expression produces a random whole number between 1 and 100.


What is rounded down by Math.floor?

shafiekwalker7861 · 2026-06-24T09:14:55Z

Hi @Luro91 , thanks for the feedback! I've addressed all of your comments:

Updated the explanation about the replaceAll() change.
Corrected the list of variable declarations.
Renamed the suggested variable to formattedMovieLength.
Tested movieLength = 3665 and updated my explanation.
Expanded the explanation of Math.random() and Math.floor().

I'd appreciate it if you could take another look. Thanks!

shafiekwalker7861 · 2026-06-24T09:18:53Z

Hi Lukas, thanks for the feedback! I've addressed all of your comments: - Updated the explanation about the replaceAll() change. - Corrected the list of variable declarations. - Renamed the suggested variable to formattedMovieLength. - Tested movieLength = 3665 and updated my explanation. - Expanded the explanation of Math.random() and Math.floor(). I'd appreciate it if you could take another look. Thanks!

…

On Wed, Jun 24, 2026 at 6:50 AM Lukas ***@***.***> wrote: ***@***.**** commented on this pull request. Good job. Most exercisers are done. I have couple of comments on some of them ------------------------------ In Sprint-1/2-mandatory-errors/3.js <#1387 (comment)> : > // Then try updating the expression last4Digits is assigned to, in order to get the correct value +const last4Digits = cardNumber % 10000; This produces an error: "Uncaught SyntaxError: redeclaration of const last4Digits". HOw can you fix this? ------------------------------ In Sprint-1/3-mandatory-interpret/1-percentage-change.js <#1387 (comment)> : > +// The error was on line 5. The replaceAll() function call was missing the correct closing bracket/parenthesis. +// I fixed it by making the line: priceAfterOneYear = Number(priceAfterOneYear.replaceAll(",", "")); The code is working now, but the change was not adding a brackent/parenthesis. What did change? ------------------------------ In Sprint-1/3-mandatory-interpret/1-percentage-change.js <#1387 (comment)> : > // d) Identify all the lines that are variable declarations +// line 1 and 2 are variable declarations because they are declared using the let keyword. Are thre other variable declarations? ------------------------------ In Sprint-1/3-mandatory-interpret/2-time-format.js <#1387 (comment)> : > // e) What do you think the variable result represents? Can you think of a better name for this variable? +// The variable result represents the total length of the movie in hours, minutes, and seconds. +// A better name for this variable could be "movieDuration". movieDuration is already better and clearer to understand. A common name for strings is to use the prefix formatted so formattedMovieLenght would also work ------------------------------ In Sprint-1/3-mandatory-interpret/2-time-format.js <#1387 (comment)> : > // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer +// The code works for non-negative whole numbers. Negative or decimal values may produce incorrect or unexpected results. What happens if the movieLength is 3665? ------------------------------ In Sprint-1/1-key-exercises/4-random.js <#1387 (comment)> : > // Try breaking down the expression and using documentation to explain what it means // It will help to think about the order in which expressions are evaluated // Try logging the value of num and running the program several times to build an idea of what the program is doing + +// Math.random() generates a random decimal, What are the characteristics of the created float number? ------------------------------ In Sprint-1/1-key-exercises/4-random.js <#1387 (comment)> : > // Try breaking down the expression and using documentation to explain what it means // It will help to think about the order in which expressions are evaluated // Try logging the value of num and running the program several times to build an idea of what the program is doing + +// Math.random() generates a random decimal, +// Math.floor() rounds it down, and the expression produces a random whole number between 1 and 100. What is rounded down by Math.floor? — Reply to this email directly, view it on GitHub <#1387?email_source=notifications&email_token=A4CDQ6SF24YZRQRIMTDFS4D5BNMY5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINJVHEYDGMBXGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4559030705>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4CDQ6QFUULSUCML6EE2CID5BNMY5AVCNFSNUABFKJSXA33TNF2G64TZHM3TSOJSGQ2TGNRYHNEXG43VMU5TINZSGQ2DIMRUGAY2C5QC> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/A4CDQ6TAU7ETM5K65ZAZDN35BNMY5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINJVHEYDGMBXGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/A4CDQ6W5327BFMMAKG34NW35BNMY5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINJVHEYDGMBXGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today! You are receiving this because you authored the thread.Message ID: <CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1387/review/4559030705 @github.com>

Luro91 · 2026-06-25T04:05:31Z

+// The error is what I predicted. The slice method is not a function that can be used on numbers, only strings.
+
 // Then try updating the expression last4Digits is assigned to, in order to get the correct value
+


When I run this code it still shows an error:
const last4Digits = cardNumber % 10000;
^

SyntaxError: Identifier 'last4Digits' has already been declared

Hi Lukas, thanks for the feedback. I think there may be a misunderstanding. In my latest commit I replaced the original line: And it outputs as per the screenshot

Luro91 · 2026-06-25T04:06:52Z

 // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
-// The error was on line 5. The replaceAll() function call was missing the correct closing bracket/parenthesis.
-// I fixed it by making the line: priceAfterOneYear = Number(priceAfterOneYear.replaceAll(",", ""));
+// I changed the value from a string to a number by wrapping the replaceAll() result in Number().


What was the error in the code and how did you fix it?

// The error was on line 5.
// After using replaceAll(), priceAfterOneYear was still a string instead of a number.
// I fixed it by wrapping the result in Number(), so it was converted to a number before doing the calculation.

Luro91 · 2026-06-25T04:08:17Z

@shafiekwalker7861 There are still 2 comments from my side. Please don't forget to add the needs review label after you are done so that I can find the PR more easily

shafiekwalker7861 · 2026-06-25T09:32:27Z

Hi Lukas, Thank you for taking the time to review my Sprint 1 submission and for your helpful feedback. I've gone through the remaining comments and updated the PR accordingly. Regarding *3.js*, I replaced the original slice() expression with: const last4Digits = cardNumber % 10000; There is now only one declaration of last4Digits in the file. I believe the redeclaration error would only occur if const last4Digits were declared a second time rather than replacing the original line. Could you please have another look and let me know if I've misunderstood the exercise? For *1-percentage-change.js*, I've updated my explanation to clarify that the issue was priceAfterOneYear remained a string after replaceAll(). I explained that wrapping the result in Number() converts it to a number before the calculation, which fixes the problem. Thank you again for your guidance and feedback. I really appreciate it and look forward to hearing if there is anything else I should improve. Kind regards, Shafiek Walker

…

On Thu, Jun 25, 2026 at 6:08 AM Lukas ***@***.***> wrote: *Luro91* left a comment (CodeYourFuture/Module-Structuring-and-Testing-Data#1387) <#1387 (comment)> @shafiekwalker7861 <https://github.com/shafiekwalker7861> There are still 2 comments from my side. Please don't forget to add the needs review label after you are done so that I can find the PR more easily — Reply to this email directly, view it on GitHub <#1387?email_source=notifications&email_token=A4CDQ6WJS663NPQES6Y4N2L5BSQUNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZGU3TONZZGQZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4795777943>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4CDQ6RVRF6WM3U7MD5XTP35BSQUNAVCNFSNUABFKJSXA33TNF2G64TZHM3TSOJSGQ2TGNRYHNEXG43VMU5TINZSGQ2DIMRUGAY2C5QC> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/A4CDQ6XOVTWQQZN266GS2BT5BSQUNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZGU3TONZZGQZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/A4CDQ6TT3LP45MFKQQQCMEL5BSQUNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZGU3TONZZGQZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today! You are receiving this because you were mentioned.Message ID: <CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1387/c4795777943@ github.com>

shafiekwalker7861 added 7 commits June 17, 2026 19:53

Complete Sprint 1 key exercises

2dfe912

Fix Sprint 1 mandatory errors

cf8fc98

Completed mandatory excercise 1

44be7d7

Completed mandatory interpret excercise 2

e109be6

Completed mandatory interpret excercise 3

a0aa43a

completed sprint-1 4 stretch-explore

1c1dcc5

completed sprint-1 4 stretch-explore objects

86d2a18

shafiekwalker7861 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 23, 2026

shafiekwalker7861 mentioned this pull request Jun 23, 2026

CAPE_TOWN | Structuring and testing data | SHAFIEK_WALKER shafiekwalker7861/My-Coursework-Planner#15

Open

Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jun 24, 2026

Luro91 reviewed Jun 24, 2026

View reviewed changes

Address reviewer feedback for Sprint 1

555030a

shafiekwalker7861 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 24, 2026

Luro91 reviewed Jun 25, 2026

View reviewed changes

Clarify error explanation in percentage-change exercise

bc6f0b8

shafiekwalker7861 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 25, 2026

		// The error was on line 5. The replaceAll() function call was missing the correct closing bracket/parenthesis.
		// I fixed it by making the line: priceAfterOneYear = Number(priceAfterOneYear.replaceAll(",", ""));



		// d) Identify all the lines that are variable declarations
		// line 1 and 2 are variable declarations because they are declared using the let keyword.

		// The error is what I predicted. The slice method is not a function that can be used on numbers, only strings.

		// Then try updating the expression last4Digits is assigned to, in order to get the correct value

Uh oh!

Uh oh!

Conversation

shafiekwalker7861 commented Jun 23, 2026

Learners, PR Template

Changelist

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shafiekwalker7861 commented Jun 24, 2026

Uh oh!

shafiekwalker7861 commented Jun 24, 2026 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Luro91 commented Jun 25, 2026

Uh oh!

shafiekwalker7861 commented Jun 25, 2026 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants