01a0aa7f - Hold external fork CI until A38 approval - #1501
TaprootFreakAI wants to merge 7 commits into
Conversation
|
EN: DE: |
|
EN: DE: DetailsQuality and logic review: complete, 0 findings at head |
|
EN: DE: Details
Durations rounded up to whole seconds / Laufzeiten auf ganze Sekunden aufgerundet. Original report / Originalbericht{
"head": "2e5da57c235e680205febc7904fbf684aaad562a",
"private": false,
"recorded_at": "2026-09-17T04:52:14Z",
"repo": "DFXswiss/app",
"required": [
"lint"
],
"runs": [
{
"command": "agent a38 job commands --config '{\"env\":{\"CI\":\"true\"},\"npm\":{\"canaries\":[\"react-app-rewired/package.json\",\"react-scripts/package.json\",\"typescript/lib/typescript.js\",\"prettier/package.json\"],\"node_major\":20},\"steps\":[[\"npm\",\"run\",\"lint\"],[\"npm\",\"run\",\"format:md:check\"]]}'",
"duration_s": 50.12718850001693,
"exit_code": 0,
"id": "lint",
"name": "Lint and Markdown format",
"result": "pass",
"timeout_s": 600.0
}
],
"schema": "dfx-local-ci/v1"
} |
|
EN: DE: Details
Durations rounded up to whole seconds / Laufzeiten auf ganze Sekunden aufgerundet. Original report / Originalbericht{
"head": "b00603077c89a9de8c96069367b0436a92806018",
"private": false,
"recorded_at": "2026-09-17T04:57:52Z",
"repo": "DFXswiss/app",
"required": [
"lint"
],
"runs": [
{
"command": "agent a38 job commands --config '{\"env\":{\"CI\":\"true\"},\"npm\":{\"canaries\":[\"react-app-rewired/package.json\",\"react-scripts/package.json\",\"typescript/lib/typescript.js\",\"prettier/package.json\"],\"node_major\":20},\"steps\":[[\"npm\",\"run\",\"lint\"],[\"npm\",\"run\",\"format:md:check\"]]}'",
"duration_s": 10.277717542019673,
"exit_code": 0,
"id": "lint",
"name": "Lint and Markdown format",
"result": "pass",
"timeout_s": 600.0
}
],
"schema": "dfx-local-ci/v1"
} |
TaprootFreak
left a comment
There was a problem hiding this comment.
A38-POLICY-APPROVAL:v1 head=b00603077c89a9de8c96069367b0436a92806018 base=d93eb60881cdf1359c131ed61dd286981aef55c8
|
EN: DE: |
CONTRIBUTING now states that fork pull-request runs from external contributors stay action_required until the guard approves them.
Product pull-request jobs wait for a required reviewer (or the A38 guard) before they run, including org-member authors.
GitHub rejects environment on a job that uses a reusable workflow, so PR CI failed to parse. Lint and Build still wait on pr-ci; E2E stays behind Build.
CONTRIBUTING and the E2E harness README now match the workflows: CodeQL skips the environment, and the reusable E2E caller waits behind Build.
The reusable E2E caller cannot take environment; the file header now matches that.
The adopter pin now tracks DFXswiss/agent develop after DFXswiss#103. The pr-guard environment_approval object stays off until this pin is live on develop, or the current guard rejects the head config.
After agent DFXswiss#104, leave-draft no longer waits for CI-AUTH when required CI is already green and nothing was held.
b006030 to
6bcf869
Compare
|
EN: DE: Details
Durations rounded up to whole seconds / Laufzeiten auf ganze Sekunden aufgerundet. Original report / Originalbericht{
"head": "6bcf869309061389ac2a83f85d3c2c86811cb181",
"private": false,
"recorded_at": "2026-09-17T08:44:33Z",
"repo": "DFXswiss/app",
"required": [
"lint"
],
"runs": [
{
"command": "agent a38 job commands --config '{\"env\":{\"CI\":\"true\"},\"npm\":{\"canaries\":[\"react-app-rewired/package.json\",\"react-scripts/package.json\",\"typescript/lib/typescript.js\",\"prettier/package.json\"],\"node_major\":20},\"steps\":[[\"npm\",\"run\",\"lint\"],[\"npm\",\"run\",\"format:md:check\"]]}'",
"duration_s": 8.53990883298684,
"exit_code": 0,
"id": "lint",
"name": "Lint and Markdown format",
"result": "pass",
"timeout_s": 600.0
}
],
"schema": "dfx-local-ci/v1"
} |
EN:
PR CI jobs wait on environment pr-ci until a required reviewer approves (Review deployments) or the A38 guard does.
This is the public-repo analog of the private-backend fork hold, including org members.
DE:
Die PR-CI-Jobs warten auf die Umgebung pr-ci, bis ein Required Reviewer (Review deployments) oder der A38-Guard freigibt.
Das ist das öffentliche Gegenstück zum privaten Backend-Fork-Hold, auch für Org-Mitglieder.
Details
Environment
pr-cirequired reviewers: davidleomay, TaprootFreak, TaprootFreakAI. Prevent self-review is off so the guard can approve with a reviewer token. Lint and Build wait on that environment; Full-stack E2E stays behind Build (GitHub forbidsenvironmenton a reusable-workflow caller job). Forkaction_requiredremains for true externals.