Repository navigation
Fix main's red colour-map test, and give the trial harness's gram the full page width - #337
Merged
Merged
Conversation
tests/player-colour-map.spec.js waited for exactly five ready players on the painting fixture, the count from before #334 and #335 grew the page: it now carries six live players (the seventh table is the deliberately bad one, which never becomes an instance). Five is a count the page only passes through, and once two players finish in the same frame it is never observed, so the wait times out. main's own run on the #335 merge fails on this test. Six is what tests/player-painting.spec.js already waits for. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CrHtVussSR8ZxsxisaepJM
Contributor
PR PreviewPreview deployment is ready! View Preview Last updated: 2026-09-18T09:29:03.988Z |
IanMayo
changed the title
This was referenced Sep 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes for main, one commit each.
1. Main's red test
Main's Tests run on the #335 merge (0531857) is red on one Playwright test:
tests/player-colour-map.spec.js› "the colour-map config row opens a table in grey or inferno, and the row shows it".The test waits for exactly five ready players on
tests/fixtures/player-painting-page.html, the count from before #334 and #335 grew that page. It now carries six live players; the seventh table is the deliberately bad one, which never becomes an instance. Five is a count the page only passes through, and once two players finish analysing in the same frame it is never observed, so the wait times out. It reproduces deterministically on unmodified main (two of two runs).One line: wait for six, which is what every wait in
tests/player-painting.spec.jsalready does, with a comment saying where the seventh table went. The same commit is already in #326, so it no-ops there once this lands.2. The trial harness was showing the component too narrow
trial/index.htmlwrapped everything, the gram included, in the 1100px column its notes read comfortably in. A component that narrow is not what an analyst's page gives it: the control row collapses its guidance and squeezes the annotation tables below about 1180px, and the picture loses half the width a full-page gram has, so the trial was showing a constrained layout as if it were the product. The gram mount now sits outside the column, spanning the page between the body's margins; the notes above and the footer below keep their column. Markup only, with a comment in the page saying why the mount is where it is.At a 1600px viewport the component is now 1552px wide against the 1100px column, and all five control-row columns show uncollapsed. The picture itself is still the player's fixed 900px render area until the expand toggle is used; that is the player's existing behaviour and is not changed here.
Checks
tests/player-colour-map.spec.json main with the fix: 4 passed; on the Rebuild the control panel to the design handoff #326 merge with it: 8 passed over two repeatsyarn build:standalone && yarn build:site && yarn check:siteon this head: site check passes (10 curated pages reachable, no dead links)🤖 Generated with Claude Code
https://claude.ai/code/session_01CrHtVussSR8ZxsxisaepJM