Skip to content

Fix main's red colour-map test, and give the trial harness's gram the full page width #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanMayo merged 1 commit into from
Sep 18, 2026
Merged

Fix main's red colour-map test, and give the trial harness's gram the full page width #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/player-colour-map.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@ test.describe('the colour-map radio row', () => {

test('the colour-map config row opens a table in grey or inferno, and the row shows it', async ({ page }) => {
await page.goto(PAINTING_PAGE)
await page.waitForFunction(() => window.GramFrame.__test__getInstances().filter(i => i.state.player.ready).length === 5)
// Six players, as tests/player-painting.spec.js waits for: the fixture's
// seventh table is the deliberately bad one, which never becomes an
// instance. Waiting for a count the page only passes through (it was 5,
// from before the fixture grew) is a race the page can skip in one frame.
await page.waitForFunction(() => window.GramFrame.__test__getInstances().filter(i => i.state.player.ready).length === 6)

const plain = await samplePixels(page, 0)
const grey = await samplePixels(page, 2)
Expand Down
Loading